Convert NavigationMetricsRecorder to use the new navigation callbacks.

Convert NavigationMetricsRecorder to use the new navigation callbacks.

BUG=682002
Review-Url: https://codereview.chromium.org/2668883002
Cr-Commit-Position: refs/heads/master@{#448361}
Committed: https://chromium.googlesource.com/chromium/src/+/db8ea2e90a1b1de4186209e52c7734f226c7ed7e

[jam, 2017-02-01 01:07:08]

Description was changed from

==========
Convert NavigationMetricsRecorder to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert NavigationMetricsRecorder to use the new navigation callbacks.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2017-02-01 01:10:11]

Description was changed from

==========
Convert NavigationMetricsRecorder to use the new navigation callbacks.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert NavigationMetricsRecorder to use the new navigation callbacks.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2017-02-01 01:10:11]

jam@chromium.org changed reviewers:
+ meacer@chromium.org

[jam, 2017-02-01 01:10:27]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 01:11:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-02-01 01:31:03]

jam@chromium.org changed reviewers:
+ clamy@chromium.org
- meacer@chromium.org

[commit-bot: I haz the power, 2017-02-01 03:15:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 03:15:06]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[jam, 2017-02-06 15:53:54]

jam@chromium.org changed reviewers:
+ nasko@chromium.org
- clamy@chromium.org

[jam, 2017-02-06 15:53:55]

->nasko

[nasko, 2017-02-06 17:28:38]

LGTM with a nit, though the linux_site_isolation bot has failed a bunch of
layout tests.

https://codereview.chromium.org/2668883002/diff/1/chrome/browser/tab_contents...
File chrome/browser/tab_contents/navigation_metrics_recorder.cc (right):

https://codereview.chromium.org/2668883002/diff/1/chrome/browser/tab_contents...
chrome/browser/tab_contents/navigation_metrics_recorder.cc:82:
content::NavigationEntry* last_committed =
nit: last_committed_entry

https://codereview.chromium.org/2668883002/diff/1/chrome/browser/tab_contents...
chrome/browser/tab_contents/navigation_metrics_recorder.cc:93: if
(last_committed->GetVirtualURL().SchemeIs(url::kDataScheme) &&
Huh, I wonder why the virtual URL is used here? I'll make a note to follow up,
since it is not related to this CL at all.

[jam, 2017-02-06 18:06:00]

https://codereview.chromium.org/2668883002/diff/1/chrome/browser/tab_contents...
File chrome/browser/tab_contents/navigation_metrics_recorder.cc (right):

https://codereview.chromium.org/2668883002/diff/1/chrome/browser/tab_contents...
chrome/browser/tab_contents/navigation_metrics_recorder.cc:82:
content::NavigationEntry* last_committed =
On 2017/02/06 17:28:38, nasko (very slow) wrote:
> nit: last_committed_entry

Done.

[jam, 2017-02-06 18:06:31]

Description was changed from

==========
Convert NavigationMetricsRecorder to use the new navigation callbacks.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert NavigationMetricsRecorder to use the new navigation callbacks.

BUG=682002
==========

[jam, 2017-02-06 18:06:34]

The CQ bit was checked by jam@chromium.org

[jam, 2017-02-06 18:06:35]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2668883002/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2017-02-06 18:06:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 18:09:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 18:09:17]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[jam, 2017-02-06 19:01:41]

Description was changed from

==========
Convert NavigationMetricsRecorder to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert NavigationMetricsRecorder to use the new navigation callbacks.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2017-02-06 19:01:55]

Description was changed from

==========
Convert NavigationMetricsRecorder to use the new navigation callbacks.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert NavigationMetricsRecorder to use the new navigation callbacks.

BUG=682002
==========

[jam, 2017-02-06 19:01:59]

The CQ bit was checked by jam@chromium.org

[jam, 2017-02-06 19:01:59]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2668883002/#ps40001
(title: "merge")

[commit-bot: I haz the power, 2017-02-06 19:03:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 19:55:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486407719417690,
"parent_rev": "e9ffc9c6104f4cc7ff5e62a94869f111c645106a", "commit_rev":
"db8ea2e90a1b1de4186209e52c7734f226c7ed7e"}

[commit-bot: I haz the power, 2017-02-06 19:55:51]

Description was changed from

==========
Convert NavigationMetricsRecorder to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert NavigationMetricsRecorder to use the new navigation callbacks.

BUG=682002

Review-Url: https://codereview.chromium.org/2668883002
Cr-Commit-Position: refs/heads/master@{#448361}
Committed:
https://chromium.googlesource.com/chromium/src/+/db8ea2e90a1b1de4186209e52c77...
==========

[commit-bot: I haz the power, 2017-02-06 19:55:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/db8ea2e90a1b1de4186209e52c77...