content/browser/frame_host/interstitial_page_navigator_impl.cc - Issue 2668883002: Convert NavigationMetricsRecorder to use the new navigation callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/interstitial_page_navigator_impl.cc

Issue 2668883002: Convert NavigationMetricsRecorder to use the new navigation callbacks. (Closed)

Patch Set: merge Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/interstitial_page_navigator_impl.cc

diff --git a/content/browser/frame_host/interstitial_page_navigator_impl.cc b/content/browser/frame_host/interstitial_page_navigator_impl.cc

index e9325d719ee9e0a13ea33d83ce8f82bd33a91a82..add3c3c72add61f417433a1629d7685d6dd2c787 100644

--- a/content/browser/frame_host/interstitial_page_navigator_impl.cc

+++ b/content/browser/frame_host/interstitial_page_navigator_impl.cc

@@ -47,7 +47,7 @@ void InterstitialPageNavigatorImpl::DidNavigate(

RenderFrameHostImpl* render_frame_host,

const FrameHostMsg_DidCommitProvisionalLoad_Params& input_params,

std::unique_ptr<NavigationHandleImpl> navigation_handle) {

- navigation_handle->DidCommitNavigation(input_params, false,

+ navigation_handle->DidCommitNavigation(input_params, false, GURL(),

render_frame_host);

navigation_handle.reset();