Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2668833002: Convert ScreenOrientation to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-screen-orientation_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ScreenOrientation to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2668833002 Cr-Commit-Position: refs/heads/master@{#447924} Committed: https://chromium.googlesource.com/chromium/src/+/96d26e24c52dabbee663af89846bea7dec057d45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M content/browser/screen_orientation/screen_orientation.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/screen_orientation/screen_orientation.cc View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jam
3 years, 10 months ago (2017-01-31 23:59:51 UTC) #7
mlamouri (slow - plz ping)
lgtm
3 years, 10 months ago (2017-02-03 02:04:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668833002/1
3 years, 10 months ago (2017-02-03 02:04:52 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 04:12:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/96d26e24c52dabbee663af89846b...

Powered by Google App Engine
This is Rietveld 408576698