content/browser/screen_orientation/screen_orientation.h - Issue 2668833002: Convert ScreenOrientation to use the new navigation callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/screen_orientation/screen_orientation.h

Issue 2668833002: Convert ScreenOrientation to use the new navigation callbacks. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/screen_orientation/screen_orientation.h

diff --git a/content/browser/screen_orientation/screen_orientation.h b/content/browser/screen_orientation/screen_orientation.h

index 68a16158a1abbff5dbddde183836a853f3c9cf88..af3d84e8120aae435468cedb18d5a92d52c4da5e 100644

--- a/content/browser/screen_orientation/screen_orientation.h

+++ b/content/browser/screen_orientation/screen_orientation.h

@@ -30,8 +30,7 @@ class ScreenOrientation : public device::mojom::ScreenOrientation,

void UnlockOrientation() override;

// WebContentsObserver:

- void DidNavigateMainFrame(const LoadCommittedDetails& details,

- const FrameNavigateParams& params) override;

+ void DidFinishNavigation(NavigationHandle* navigation_handle) override;

std::unique_ptr<ScreenOrientationProvider> provider_;

WebContentsFrameBindingSet<device::mojom::ScreenOrientation> bindings_;

« no previous file with comments | « no previous file | content/browser/screen_orientation/screen_orientation.cc » ('j') | no next file with comments »