Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2668763005: s390: fix shift operand overflow (Closed)

Created:
3 years, 10 months ago by john.yan
Modified:
3 years, 10 months ago
Reviewers:
JoranSiu, JaideepBajwa
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: fix shift operand overflow R=bjaideep@ca.ibm.com, joransiu@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2668763005 Cr-Commit-Position: refs/heads/master@{#42868} Committed: https://chromium.googlesource.com/v8/v8/+/8877a3883fa3dae697a71b2577cae4c3eedbd6e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -16 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 8 chunks +21 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
john.yan
ptal
3 years, 10 months ago (2017-02-01 18:51:05 UTC) #1
JaideepBajwa
lgtm
3 years, 10 months ago (2017-02-01 18:56:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668763005/1
3 years, 10 months ago (2017-02-01 18:57:04 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-01 18:57:06 UTC) #6
JoranSiu
On 2017/02/01 18:57:06, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 10 months ago (2017-02-01 20:20:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668763005/1
3 years, 10 months ago (2017-02-01 20:22:16 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 20:29:07 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8877a3883fa3dae697a71b2577cae4c3eed...

Powered by Google App Engine
This is Rietveld 408576698