Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: pkg/compiler/lib/src/serialization/equivalence.dart

Issue 2668723002: Handle JS-calls in impact_test. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/kernel/world_builder.dart ('k') | tests/compiler/dart2js/kernel/impact_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/serialization/equivalence.dart
diff --git a/pkg/compiler/lib/src/serialization/equivalence.dart b/pkg/compiler/lib/src/serialization/equivalence.dart
index 91110d1ee5000d9dd961bc7e310c409d8abd73c0..6c5e43217d24a10a5e2aa2a9c6e80970f40efcee 100644
--- a/pkg/compiler/lib/src/serialization/equivalence.dart
+++ b/pkg/compiler/lib/src/serialization/equivalence.dart
@@ -1069,7 +1069,7 @@ bool testResolutionImpactEquivalence(
impact2.typeUses,
(a, b) => areTypeUsesEquivalent(a, b, strategy: strategy.testOnly)) &&
strategy.testSets(impact1, impact2, 'nativeData', impact1.nativeData,
- impact2.nativeData, testNativeBehavior);
+ impact2.nativeData, (a, b) => testNativeBehavior(a, b, strategy: strategy));
Siggi Cherem (dart-lang) 2017/01/31 21:51:47 nit dartfmt
Johnni Winther 2017/02/01 09:17:39 Done.
}
/// Tests the equivalence of [resolvedAst1] and [resolvedAst2] using [strategy].
@@ -1137,7 +1137,7 @@ bool testTreeElementsEquivalence(
}
bool testNativeBehavior(NativeBehavior a, NativeBehavior b,
- [TestStrategy strategy = const TestStrategy()]) {
+ {TestStrategy strategy = const TestStrategy()}) {
if (identical(a, b)) return true;
if (a == null || b == null) return false;
return strategy.test(
@@ -1224,7 +1224,7 @@ class TreeElementsEquivalenceVisitor extends Visitor {
if (identical(a, b)) return true;
if (a == null || b == null) return false;
if (a is NativeBehavior && b is NativeBehavior) {
- return testNativeBehavior(a, b, strategy);
+ return testNativeBehavior(a, b, strategy: strategy);
}
return true;
}
« no previous file with comments | « pkg/compiler/lib/src/kernel/world_builder.dart ('k') | tests/compiler/dart2js/kernel/impact_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698