Handle JS-calls in impact_test.

pkg/compiler/lib/src/serialization/equivalence.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Functions for asserting equivalence across serialization.
 
 library dart2js.serialization.equivalence;
 
 import '../closure.dart';
 import '../common/resolution.dart';
@@ skipping 1051 matching lines @@
           (a, b) =>
               areStaticUsesEquivalent(a, b, strategy: strategy.testOnly)) &&
       strategy.testSets(
           impact1,
           impact2,
           'typeUses',
           impact1.typeUses,
           impact2.typeUses,
           (a, b) => areTypeUsesEquivalent(a, b, strategy: strategy.testOnly)) &&
       strategy.testSets(impact1, impact2, 'nativeData', impact1.nativeData,
-          impact2.nativeData, testNativeBehavior);
+          impact2.nativeData, (a, b) => testNativeBehavior(a, b, strategy: strategy));

[Siggi Cherem (dart-lang), 2017/01/31 21:51:47]

nit dartfmt

[Johnni Winther, 2017/02/01 09:17:39]

Done.

 }
 
 /// Tests the equivalence of [resolvedAst1] and [resolvedAst2] using [strategy].
 bool testResolvedAstEquivalence(
     ResolvedAst resolvedAst1, ResolvedAst resolvedAst2,
     [TestStrategy strategy = const TestStrategy()]) {
   if (!strategy.test(resolvedAst1, resolvedAst1, 'kind', resolvedAst1.kind,
       resolvedAst2.kind)) {
     return false;
   }
@@ skipping 47 matching lines @@
       indices1, indices2, elements1, elements2, strategy);
   resolvedAst1.node.accept(visitor);
   if (visitor.success) {
     return strategy.test(elements1, elements2, 'containsTryStatement',
         elements1.containsTryStatement, elements2.containsTryStatement);
   }
   return false;
 }
 
 bool testNativeBehavior(NativeBehavior a, NativeBehavior b,
-    [TestStrategy strategy = const TestStrategy()]) {
+    {TestStrategy strategy = const TestStrategy()}) {
   if (identical(a, b)) return true;
   if (a == null || b == null) return false;
   return strategy.test(
           a, b, 'codeTemplateText', a.codeTemplateText, b.codeTemplateText) &&
       strategy.test(a, b, 'isAllocation', a.isAllocation, b.isAllocation) &&
       strategy.test(a, b, 'sideEffects', a.sideEffects, b.sideEffects) &&
       strategy.test(a, b, 'throwBehavior', a.throwBehavior, b.throwBehavior) &&
       strategy.testTypeLists(
           a,
           b,
@@ skipping 66 matching lines @@
         strategy.test(
             a, b, 'isBreakTarget', a.isBreakTarget, b.isBreakTarget) &&
         strategy.test(
             a, b, 'isContinueTarget', a.isContinueTarget, b.isContinueTarget);
   }
 
   bool testNativeData(Node node1, Node node2, String property, a, b) {
     if (identical(a, b)) return true;
     if (a == null || b == null) return false;
     if (a is NativeBehavior && b is NativeBehavior) {
-      return testNativeBehavior(a, b, strategy);
+      return testNativeBehavior(a, b, strategy: strategy);
     }
     return true;
   }
 
   visitNode(Node node1) {
     if (!success) return;
     int index = indices1.nodeIndices[node1];
     Node node2 = indices2.nodeList[index];
     success = strategy.testElements(
             node1, node2, '[$index]', elements1[node1], elements2[node2]) &&
@@ skipping 872 matching lines @@
 }
 
 bool areMetadataAnnotationsEquivalent(
     MetadataAnnotation metadata1, MetadataAnnotation metadata2) {
   if (metadata1 == metadata2) return true;
   if (metadata1 == null || metadata2 == null) return false;
   return areElementsEquivalent(
           metadata1.annotatedElement, metadata2.annotatedElement) &&
       areConstantsEquivalent(metadata1.constant, metadata2.constant);
 }