Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: pkg/compiler/lib/src/kernel/world_builder.dart

Issue 2668723002: Handle JS-calls in impact_test. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/kernel/world_builder.dart
diff --git a/pkg/compiler/lib/src/kernel/world_builder.dart b/pkg/compiler/lib/src/kernel/world_builder.dart
index fa83e31b80623cb54282a1c198ddc1d2abea45df..a86f41d8cb57f5923d673bcb799c54bb6e3b21f5 100644
--- a/pkg/compiler/lib/src/kernel/world_builder.dart
+++ b/pkg/compiler/lib/src/kernel/world_builder.dart
@@ -212,30 +212,13 @@ class KernelWorldBuilder extends KernelElementAdapterMixin {
}
@override
- InterfaceType getRawType(ClassEntity cls) {
- throw new UnimplementedError('KernelWorldBuilder.getRawType');
- }
-
- @override
- InterfaceType getInterfaceTypeForJsInterceptorCall(ir.StaticInvocation node) {
- throw new UnimplementedError('KernelWorldBuilder.getDartType');
- }
-
- @override
- native.NativeBehavior getNativeBehaviorForJsEmbeddedGlobalCall(
- ir.StaticInvocation node) {
- throw new UnimplementedError('KernelWorldBuilder.getDartType');
- }
-
- @override
- native.NativeBehavior getNativeBehaviorForJsBuiltinCall(
- ir.StaticInvocation node) {
- throw new UnimplementedError('KernelWorldBuilder.getDartType');
- }
-
- @override
- native.NativeBehavior getNativeBehaviorForJsCall(ir.StaticInvocation node) {
- throw new UnimplementedError('KernelWorldBuilder.getDartType');
+ InterfaceType getRawType(KClass cls) {
+ KClassEnv env = _classEnvs[cls.classIndex];
+ ir.Class node = env.cls;
+ // TODO(johnniwinther): Add the type argument to the list literal when we
+ // no longer use resolution types.
+ return new InterfaceType(cls, new List/*<DartType>*/.filled(
+ node.typeParameters.length, const DynamicType()));
}
@override
@@ -358,7 +341,7 @@ class KernelCommonElements extends CommonElementsMixin {
@override
InterfaceType getRawType(ClassEntity cls) {
- throw new UnimplementedError('KernelCommonElements.getRawType');
+ return worldBuilder.getRawType(cls);
}
@override

Powered by Google App Engine
This is Rietveld 408576698