[stubs] Add RegExpReplace and RegExpSplit stubs

[stubs] Add RegExpReplace and RegExpSplit stubs

This adds helper stubs for RegExp split and replace operations, called directly
by both RegExpPrototype{Replace,Split} and StringPrototype{Replace,Split}.

BUG=

Review-Url: https://codereview.chromium.org/2668703002
Cr-Commit-Position: refs/heads/master@{#42919}
Committed: https://chromium.googlesource.com/v8/v8/+/082bf30604a357bc318a627165b4d6f7ea097006

[jgruber, 2017-01-31 14:45:58]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 14:46:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 14:54:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 14:54:10]

Dry run: Try jobs failed on following builders:
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)

[jgruber, 2017-02-01 15:24:47]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 15:24:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 15:31:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 15:31:42]

Dry run: Try jobs failed on following builders:
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)

[jgruber, 2017-02-02 08:19:04]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 08:19:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 08:39:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 08:39:09]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[jgruber, 2017-02-02 11:32:16]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 11:32:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-02-02 11:41:38]

jgruber@chromium.org changed reviewers:
+ ishell@chromium.org

[jgruber, 2017-02-02 11:41:39]

Hey Igor, ptal. 

This adds fast paths for when String.p.{replace,split} are called with a regexp
argument. RegExp.p[{@@replace,@@split}] now call the new replace/split stubs
after some initial checks to increase code reuse.

[commit-bot: I haz the power, 2017-02-02 11:58:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 11:58:58]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2017-02-03 09:17:54]

lgtm if you revert BranchIfFastRegExp() -> Branch(IsFastRegExp()...) changes.

https://codereview.chromium.org/2668703002/diff/60001/src/builtins/builtins-r...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2668703002/diff/60001/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:427: Variable var_result(this,
MachineRepresentation::kWord32, Int32Constant(0));
Although the use cases look nicer with this change, I think the old version is
better because it does not require an additional register for var_result and the
generated code should be simpler.

I'd suggest to leave BranchIfFastRegExp() unchanged and implement
IsFastRegExpMap() via BranchIfFastRegExp(). And maybe add a comment that Is
version is for using in asserts.

[jgruber, 2017-02-03 09:58:12]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 09:58:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 10:26:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 10:26:22]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-02-03 10:29:28]

https://codereview.chromium.org/2668703002/diff/60001/src/builtins/builtins-r...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2668703002/diff/60001/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:427: Variable var_result(this,
MachineRepresentation::kWord32, Int32Constant(0));
On 2017/02/03 09:17:54, Igor Sheludko wrote:
> Although the use cases look nicer with this change, I think the old version is
> better because it does not require an additional register for var_result and
the
> generated code should be simpler.
> 
> I'd suggest to leave BranchIfFastRegExp() unchanged and implement
> IsFastRegExpMap() via BranchIfFastRegExp(). And maybe add a comment that Is
> version is for using in asserts.

Done.

[jgruber, 2017-02-03 10:29:40]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-02-03 10:29:40]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2668703002/#ps80001
(title: "BranchIfFastRegExp/IsFastRegExpMap")

[commit-bot: I haz the power, 2017-02-03 10:29:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 10:31:30]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486117780292860,
"parent_rev": "87e53cb85ae871b8f95dd19058cac438c57aa751", "commit_rev":
"082bf30604a357bc318a627165b4d6f7ea097006"}

[commit-bot: I haz the power, 2017-02-03 10:31:38]

Description was changed from

==========
[stubs] Add RegExpReplace and RegExpSplit stubs

This adds helper stubs for RegExp split and replace operations, called directly
by both RegExpPrototype{Replace,Split} and StringPrototype{Replace,Split}.

BUG=
==========

to

==========
[stubs] Add RegExpReplace and RegExpSplit stubs

This adds helper stubs for RegExp split and replace operations, called directly
by both RegExpPrototype{Replace,Split} and StringPrototype{Replace,Split}.

BUG=

Review-Url: https://codereview.chromium.org/2668703002
Cr-Commit-Position: refs/heads/master@{#42919}
Committed:
https://chromium.googlesource.com/v8/v8/+/082bf30604a357bc318a627165b4d6f7ea0...
==========

[commit-bot: I haz the power, 2017-02-03 10:31:38]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/082bf30604a357bc318a627165b4d6f7ea0...