[stubs] Add RegExpReplace and RegExpSplit stubs

src/builtins/builtins-string.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins-regexp.h"
 #include "src/builtins/builtins-utils.h"
 #include "src/builtins/builtins.h"
 #include "src/code-factory.h"
 #include "src/code-stub-assembler.h"
 #include "src/regexp/regexp-utils.h"
@@ skipping 1097 matching lines @@
     Node* const initial_map =
         LoadObjectField(string_fun, JSFunction::kPrototypeOrInitialMapOffset);
     Node* const proto_map = LoadMap(LoadMapPrototype(initial_map));
 
     Branch(WordEqual(proto_map, initial_proto_initial_map), &out, &next);
 
     Bind(&next);
   }
 
   // Take the fast path for RegExps.
-  if (regexp_call != nullptr) {
+  {
     Label stub_call(this), slow_lookup(this);
 
     RegExpBuiltinsAssembler regexp_asm(state());
     regexp_asm.BranchIfFastRegExp(context, object_map, &stub_call,
                                   &slow_lookup);
 
     Bind(&stub_call);
     Return(regexp_call());
 
     Bind(&slow_lookup);
@@ skipping 24 matching lines @@
   Node* const receiver = Parameter(0);
   Node* const search = Parameter(1);
   Node* const replace = Parameter(2);
   Node* const context = Parameter(5);
 
   Node* const smi_zero = SmiConstant(0);
 
   RequireObjectCoercible(context, receiver, "String.prototype.replace");
 
   // Redirect to replacer method if {search[@@replace]} is not undefined.
-  // TODO(jgruber): Call RegExp.p.replace stub for fast path.
 
   MaybeCallFunctionAtSymbol(
-      context, search, isolate()->factory()->replace_symbol(), nullptr,
+      context, search, isolate()->factory()->replace_symbol(),
+      [=]() {
+        Callable tostring_callable = CodeFactory::ToString(isolate());
+        Node* const subject_string =
+            CallStub(tostring_callable, context, receiver);
+
+        Callable replace_callable = CodeFactory::RegExpReplace(isolate());
+        return CallStub(replace_callable, context, search, subject_string,
+                        replace);
+      },
       [=](Node* fn) {
         Callable call_callable = CodeFactory::Call(isolate());
         return CallJS(call_callable, context, fn, search, receiver, replace);
       });
 
   // Convert {receiver} and {search} to strings.
 
   Callable tostring_callable = CodeFactory::ToString(isolate());
   Node* const subject_string = CallStub(tostring_callable, context, receiver);
   Node* const search_string = CallStub(tostring_callable, context, search);
@@ skipping 133 matching lines @@
   Node* const receiver = Parameter(0);
   Node* const separator = Parameter(1);
   Node* const limit = Parameter(2);
   Node* const context = Parameter(5);
 
   Node* const smi_zero = SmiConstant(0);
 
   RequireObjectCoercible(context, receiver, "String.prototype.split");
 
   // Redirect to splitter method if {separator[@@split]} is not undefined.
-  // TODO(jgruber): Call RegExp.p.split stub for fast path.
 
   MaybeCallFunctionAtSymbol(
-      context, separator, isolate()->factory()->split_symbol(), nullptr,
+      context, separator, isolate()->factory()->split_symbol(),
+      [=]() {
+        Callable tostring_callable = CodeFactory::ToString(isolate());
+        Node* const subject_string =
+            CallStub(tostring_callable, context, receiver);
+
+        Callable split_callable = CodeFactory::RegExpSplit(isolate());
+        return CallStub(split_callable, context, separator, subject_string,
+                        limit);
+      },
       [=](Node* fn) {
         Callable call_callable = CodeFactory::Call(isolate());
         return CallJS(call_callable, context, fn, separator, receiver, limit);
       });
 
   // String and integer conversions.
   // TODO(jgruber): The old implementation used Uint32Max instead of SmiMax -
   // but AFAIK there should not be a difference since arrays are capped at Smi
   // lengths.
 
@@ skipping 521 matching lines @@
         CallRuntime(Runtime::kThrowIncompatibleMethodReceiver, context,
                     HeapConstant(factory()->NewStringFromAsciiChecked(
                         "String Iterator.prototype.next", TENURED)),
                     iterator);
     Return(result);  // Never reached.
   }
 }
 
 }  // namespace internal
 }  // namespace v8