MD Settings: Fix remaining tests that fail in Vulcanized mode.

MD Settings: Fix remaining tests that fail in Vulcanized mode.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2668623002
Cr-Commit-Position: refs/heads/master@{#449771}
Committed: https://chromium.googlesource.com/chromium/src/+/7fb2a54485b5b77c484832df424aae5defd8304f

[dpapad, 2017-01-31 01:49:21]

Description was changed from

==========
DO NOT SUMBIT YET, fix some tests when run in vulcanized mode.

BUG=
==========

to

==========
DO NOT SUMBIT YET, fix some tests when run in vulcanized mode.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-01 23:57:06]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 23:57:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 00:57:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 00:57:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2017-02-03 22:49:07]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-02-03 22:49:08]

https://codereview.chromium.org/2668623002/diff/130001/chrome/test/data/webui...
File
chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
(right):

https://codereview.chromium.org/2668623002/diff/130001/chrome/test/data/webui...
chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js:191:
if (!USE_VULCANIZE) {
can you (for now) just check to see if some public symbol exported by this file
already exists?

i.e.

if (!window.CrSettingsPrefs) {

or make the Polymer({is: 'settings-prefs'}) actually export to window. or
settings.

https://codereview.chromium.org/2668623002/diff/130001/chrome/test/data/webui...
File chrome/test/data/webui/settings/reset_page_test.js (right):

https://codereview.chromium.org/2668623002/diff/130001/chrome/test/data/webui...
chrome/test/data/webui/settings/reset_page_test.js:84: if (!USE_VULCANIZE) {
same

https://codereview.chromium.org/2668623002/diff/130001/chrome/test/data/webui...
File chrome/test/data/webui/settings/search_settings_test.js (right):

https://codereview.chromium.org/2668623002/diff/130001/chrome/test/data/webui...
chrome/test/data/webui/settings/search_settings_test.js:11: if (!USE_VULCANIZE)
{
if (settings.SearchRequest)?

https://codereview.chromium.org/2668623002/diff/130001/chrome/test/data/webui...
File chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
(right):

https://codereview.chromium.org/2668623002/diff/130001/chrome/test/data/webui...
chrome/test/data/webui/settings/settings_passwords_section_browsertest.js:175:
//assertEquals(self.browsePreload, document.location.href);
remove it, maybe?  is this because of the <base> tag?

this is a failure because of a browsePreload I'd guess ;)

[dpapad, 2017-02-03 23:18:16]

https://codereview.chromium.org/2668623002/diff/130001/chrome/test/data/webui...
File chrome/test/data/webui/settings/reset_page_test.js (right):

https://codereview.chromium.org/2668623002/diff/130001/chrome/test/data/webui...
chrome/test/data/webui/settings/reset_page_test.js:84: if (!USE_VULCANIZE) {
On 2017/02/03 at 22:49:08, Dan Beam (slow) wrote:
> same

I have already sent a separate CL for this
(https://codereview.chromium.org/2676643005). This CL here is not for review
yet. I just use it to discover what is left to fix.

[Dan Beam, 2017-02-08 05:18:22]

Description was changed from

==========
DO NOT SUMBIT YET, fix some tests when run in vulcanized mode.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
DO NOT SUMBIT YET, fix some tests when run in vulcanized mode.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-08 23:56:09]

dpapad@chromium.org changed reviewers:
- dbeam@chromium.org

[dpapad, 2017-02-08 23:57:05]

Patchset #9 (id:150001) has been deleted

[dpapad, 2017-02-10 03:44:09]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 03:44:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-02-10 03:46:07]

Description was changed from

==========
DO NOT SUMBIT YET, fix some tests when run in vulcanized mode.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix remaining tests that fail in Vulcanized mode.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-02-10 05:32:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 05:32:22]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-02-10 18:02:49]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2017-02-10 18:02:50]

https://codereview.chromium.org/2668623002/diff/170001/chrome/test/data/webui...
File chrome/test/data/webui/settings/people_page_sync_page_test.js (right):

https://codereview.chromium.org/2668623002/diff/170001/chrome/test/data/webui...
chrome/test/data/webui/settings/people_page_sync_page_test.js:276: link.href =
'#';
link.onclick = preventdefault.

[dpapad, 2017-02-10 18:03:29]

https://codereview.chromium.org/2668623002/diff/170001/chrome/test/data/webui...
File chrome/test/data/webui/settings/people_page_sync_page_test.js (right):

https://codereview.chromium.org/2668623002/diff/170001/chrome/test/data/webui...
chrome/test/data/webui/settings/people_page_sync_page_test.js:276: link.href =
'#';
On 2017/02/10 at 18:02:50, dpapad wrote:
> link.onclick = preventdefault.

Ignore this, it was a note to myself from a previous patch.

[Dan Beam, 2017-02-10 22:38:05]

lgtm

[dpapad, 2017-02-10 22:41:52]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-02-10 22:42:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 22:48:58]

CQ is committing da patch.

Bot data: {"patchset_id": 230001, "attempt_start_ts": 1486766512873070,
"parent_rev": "5d87c3aad9d1276390112859ec0f6a4b3ca89adc", "commit_rev":
"7fb2a54485b5b77c484832df424aae5defd8304f"}

[commit-bot: I haz the power, 2017-02-10 22:49:37]

Description was changed from

==========
MD Settings: Fix remaining tests that fail in Vulcanized mode.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix remaining tests that fail in Vulcanized mode.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2668623002
Cr-Commit-Position: refs/heads/master@{#449771}
Committed:
https://chromium.googlesource.com/chromium/src/+/7fb2a54485b5b77c484832df424a...
==========

[commit-bot: I haz the power, 2017-02-10 22:49:38]

Committed patchset #12 (id:230001) as
https://chromium.googlesource.com/chromium/src/+/7fb2a54485b5b77c484832df424a...