MD Settings: Fix reset_page_test.js in Vulcanized mode

MD Settings: Fix reset_page_test.js in Vulcanized mode.

ResetProfileBanner was being tested as part of reset_page.html unit
tests, but it is not a dependency of that page, so it was using
importHtml() to load it.

 - Move TestResetBrowserProxy to its own file so it can be reused by both tests.
 - Move ResetProfileBanner tests to their own file and C++ fixture and remove
   importHtml() call from reset_page_test.js.
 - Add missing HTML imports as necessary.
 - Remove unnecessary register*Tests() wrappers.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2676643005
Cr-Commit-Position: refs/heads/master@{#448550}
Committed: https://chromium.googlesource.com/chromium/src/+/934271eaabb521f8d19d016801459f9ae9eb7ad5

[dpapad, 2017-02-03 19:25:06]

Description was changed from

==========
MD Settings: Move reset_profile_banner tests to their own Test class.

This fixes reset_page_tests.js in Vulcanized mode, such that it does not need to
import any dependencies using importHtml(). ResetProfileBanner was being tested
as part of reset_page.html tests, but it was not a direct dependency of that
page.

BUG=673825
==========

to

==========
MD Settings: Move reset_profile_banner tests to their own Test class.

This fixes reset_page_tests.js in Vulcanized mode, such that it does not need to
import any dependencies using importHtml(). ResetProfileBanner was being tested
as part of reset_page.html tests, but it was not a direct dependency of that
page.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-03 19:25:25]

Description was changed from

==========
MD Settings: Move reset_profile_banner tests to their own Test class.

This fixes reset_page_tests.js in Vulcanized mode, such that it does not need to
import any dependencies using importHtml(). ResetProfileBanner was being tested
as part of reset_page.html tests, but it was not a direct dependency of that
page.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Move reset_profile_banner tests to their own Test class.

This fixes reset_page_tests.js in Vulcanized mode, such that it does not need to
import any dependencies using importHtml(). ResetProfileBanner was being tested
as part of reset_page.html tests, but it is not a dependency of that
page.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-03 19:26:28]

Description was changed from

==========
MD Settings: Move reset_profile_banner tests to their own Test class.

This fixes reset_page_tests.js in Vulcanized mode, such that it does not need to
import any dependencies using importHtml(). ResetProfileBanner was being tested
as part of reset_page.html tests, but it is not a dependency of that
page.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Move reset_profile_banner tests to their own Test class.

This fixes reset_page_tests.js in Vulcanized mode, such that it does not need to
import any dependencies using importHtml(). ResetProfileBanner was being tested
as part of reset_page.html tests, but it is not a dependency of that
page.

 - Move TestResetBrowserProxy to its own file so it can be reused by both tests.
 - Move ResetProfileBanner tests to their own file and C++ fixture.
 - Add missing HTML imports as necessary.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-03 19:26:48]

Description was changed from

==========
MD Settings: Move reset_profile_banner tests to their own Test class.

This fixes reset_page_tests.js in Vulcanized mode, such that it does not need to
import any dependencies using importHtml(). ResetProfileBanner was being tested
as part of reset_page.html tests, but it is not a dependency of that
page.

 - Move TestResetBrowserProxy to its own file so it can be reused by both tests.
 - Move ResetProfileBanner tests to their own file and C++ fixture.
 - Add missing HTML imports as necessary.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Move reset_profile_banner tests to their own Test class.

This fixes reset_page_tests.js in Vulcanized mode, such that it does not need to
import any dependencies using importHtml(). ResetProfileBanner was being tested
as part of reset_page.html tests, but it is not a dependency of that
page.

 - Move TestResetBrowserProxy to its own file so it can be reused by both tests.
 - Move ResetProfileBanner tests to their own file and C++ fixture.
 - Add missing HTML imports as necessary.
 - Remove unnecessary register*Tests() wrappers.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-03 19:27:17]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 19:27:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-02-03 19:32:36]

Description was changed from

==========
MD Settings: Move reset_profile_banner tests to their own Test class.

This fixes reset_page_tests.js in Vulcanized mode, such that it does not need to
import any dependencies using importHtml(). ResetProfileBanner was being tested
as part of reset_page.html tests, but it is not a dependency of that
page.

 - Move TestResetBrowserProxy to its own file so it can be reused by both tests.
 - Move ResetProfileBanner tests to their own file and C++ fixture.
 - Add missing HTML imports as necessary.
 - Remove unnecessary register*Tests() wrappers.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Move reset_profile_banner tests to their own Test class.

This fixes reset_page_test.js in Vulcanized mode, such that it does not need to
import any dependencies using importHtml(). ResetProfileBanner was being tested
as part of reset_page.html unit tests, but it is not a dependency of that
page.

 - Move TestResetBrowserProxy to its own file so it can be reused by both tests.
 - Move ResetProfileBanner tests to their own file and C++ fixture.
 - Add missing HTML imports as necessary.
 - Remove unnecessary register*Tests() wrappers.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-03 20:03:32]

Description was changed from

==========
MD Settings: Move reset_profile_banner tests to their own Test class.

This fixes reset_page_test.js in Vulcanized mode, such that it does not need to
import any dependencies using importHtml(). ResetProfileBanner was being tested
as part of reset_page.html unit tests, but it is not a dependency of that
page.

 - Move TestResetBrowserProxy to its own file so it can be reused by both tests.
 - Move ResetProfileBanner tests to their own file and C++ fixture.
 - Add missing HTML imports as necessary.
 - Remove unnecessary register*Tests() wrappers.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix reset_page_test.js in Vulcanized mode.

ResetProfileBanner was being test as part of reset_page.html unit
tests, but it is not a dependency of that page, so it was using
importHtml() to load it.

 - Move TestResetBrowserProxy to its own file so it can be reused by both tests.
 - Move ResetProfileBanner tests to their own file and C++ fixture and remove
   importHtml() call from reset_page_test.js.
 - Add missing HTML imports as necessary.
 - Remove unnecessary register*Tests() wrappers.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-03 20:05:00]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2017-02-03 20:05:01]

https://codereview.chromium.org/2676643005/diff/1/chrome/test/data/webui/sett...
File chrome/test/data/webui/settings/reset_page_test.js (right):

https://codereview.chromium.org/2676643005/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/reset_page_test.js:6: var TestNames = {
The diff in this file is a bit misleading, because I changed the indentation
after removing the register*Tests() wrappers. The actual change is pulling out
banner related stuff to the other test file.

[commit-bot: I haz the power, 2017-02-03 20:41:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 20:41:01]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-02-03 23:23:27]

Description was changed from

==========
MD Settings: Fix reset_page_test.js in Vulcanized mode.

ResetProfileBanner was being test as part of reset_page.html unit
tests, but it is not a dependency of that page, so it was using
importHtml() to load it.

 - Move TestResetBrowserProxy to its own file so it can be reused by both tests.
 - Move ResetProfileBanner tests to their own file and C++ fixture and remove
   importHtml() call from reset_page_test.js.
 - Add missing HTML imports as necessary.
 - Remove unnecessary register*Tests() wrappers.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix reset_page_test.js in Vulcanized mode.

ResetProfileBanner was being tested as part of reset_page.html unit
tests, but it is not a dependency of that page, so it was using
importHtml() to load it.

 - Move TestResetBrowserProxy to its own file so it can be reused by both tests.
 - Move ResetProfileBanner tests to their own file and C++ fixture and remove
   importHtml() call from reset_page_test.js.
 - Add missing HTML imports as necessary.
 - Remove unnecessary register*Tests() wrappers.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-06 21:49:35]

Friendly ping.

[Dan Beam, 2017-02-06 21:50:41]

https://codereview.chromium.org/2676643005/diff/1/chrome/test/data/webui/sett...
File chrome/test/data/webui/settings/reset_page_test.js (left):

https://codereview.chromium.org/2676643005/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/reset_page_test.js:5:
cr.define('settings_reset_page', function() {
can you unwrap this in a separate CL?

[dpapad, 2017-02-06 23:06:32]

https://codereview.chromium.org/2676643005/diff/1/chrome/test/data/webui/sett...
File chrome/test/data/webui/settings/reset_page_test.js (left):

https://codereview.chromium.org/2676643005/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/reset_page_test.js:5:
cr.define('settings_reset_page', function() {
On 2017/02/06 at 21:50:41, Dan Beam (slow) wrote:
> can you unwrap this in a separate CL?

Done.

[Dan Beam, 2017-02-07 03:00:39]

lgtm

[dpapad, 2017-02-07 03:02:18]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-02-07 03:02:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 04:54:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486436538139120,
"parent_rev": "ba48072770ed46f3328f09d8147f42c8cf4a1677", "commit_rev":
"934271eaabb521f8d19d016801459f9ae9eb7ad5"}

[commit-bot: I haz the power, 2017-02-07 04:55:26]

Description was changed from

==========
MD Settings: Fix reset_page_test.js in Vulcanized mode.

ResetProfileBanner was being tested as part of reset_page.html unit
tests, but it is not a dependency of that page, so it was using
importHtml() to load it.

 - Move TestResetBrowserProxy to its own file so it can be reused by both tests.
 - Move ResetProfileBanner tests to their own file and C++ fixture and remove
   importHtml() call from reset_page_test.js.
 - Add missing HTML imports as necessary.
 - Remove unnecessary register*Tests() wrappers.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix reset_page_test.js in Vulcanized mode.

ResetProfileBanner was being tested as part of reset_page.html unit
tests, but it is not a dependency of that page, so it was using
importHtml() to load it.

 - Move TestResetBrowserProxy to its own file so it can be reused by both tests.
 - Move ResetProfileBanner tests to their own file and C++ fixture and remove
   importHtml() call from reset_page_test.js.
 - Add missing HTML imports as necessary.
 - Remove unnecessary register*Tests() wrappers.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2676643005
Cr-Commit-Position: refs/heads/master@{#448550}
Committed:
https://chromium.googlesource.com/chromium/src/+/934271eaabb521f8d19d01680145...
==========

[commit-bot: I haz the power, 2017-02-07 04:55:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/934271eaabb521f8d19d01680145...