Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2668583008: DevTools: track Node.js UMA (Closed)

Created:
3 years, 10 months ago by chenwilliam
Modified:
3 years, 10 months ago
CC:
apavlov+blink_chromium.org, asvitkine+watch_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: track Node.js UMA This tracks two metrics: - Connect to node.js from frontend - Connect to node.js directly (paste link from CLI) The sum of these two metrics should be total sessions debugging node.js. BUG=667831 Review-Url: https://codereview.chromium.org/2668583008 Cr-Commit-Position: refs/heads/master@{#447678} Committed: https://chromium.googlesource.com/chromium/src/+/9140e1983161fb820586389b1a77596fef4f835a

Patch Set 1 #

Patch Set 2 : rebaseline test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/inspector/user-metrics-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/UserMetrics.js View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
chenwilliam
ptal
3 years, 10 months ago (2017-02-01 18:20:27 UTC) #2
pfeldman
lgtm
3 years, 10 months ago (2017-02-01 18:26:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668583008/20001
3 years, 10 months ago (2017-02-01 23:42:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/355127)
3 years, 10 months ago (2017-02-01 23:52:31 UTC) #8
chenwilliam
@isherman - can you take a look at the histograms.xml?
3 years, 10 months ago (2017-02-02 00:11:38 UTC) #10
Ilya Sherman
histograms.xml lgtm
3 years, 10 months ago (2017-02-02 00:58:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668583008/20001
3 years, 10 months ago (2017-02-02 01:11:57 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 01:48:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9140e1983161fb820586389b1a77...

Powered by Google App Engine
This is Rietveld 408576698