Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Issue 2668583008: DevTools: track Node.js UMA (Closed)
Patch Set: rebaseline test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
index 992546edfc2e4d090a07665e51b5a5187df2fa05..ad7ae10725272c16073d4495aef921d3cd45f322 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
@@ -331,6 +331,7 @@ SDK.TargetManager = class extends Common.Object {
this, Common.UIString('Node'), SDK.Target.Capability.Target, this._createMainConnection.bind(this), null);
target.subTargetsManager = new SDK.SubTargetsManager(target);
target.setInspectedURL('Node');
+ Host.userMetrics.actionTaken(Host.UserMetrics.Action.ConnectToNodeJSFromFrontend);
return;
}
@@ -341,6 +342,7 @@ SDK.TargetManager = class extends Common.Object {
SDK.Target.Capability.Target;
} else if (Runtime.queryParam('v8only')) {
capabilities = SDK.Target.Capability.JS;
+ Host.userMetrics.actionTaken(Host.UserMetrics.Action.ConnectToNodeJSDirectly);
}
var target = this.createTarget(Common.UIString('Main'), capabilities, this._createMainConnection.bind(this), null);
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/host/UserMetrics.js ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698