Migrate WebGL timers to TaskRunnerTimer

Migrate WebGL timers to TaskRunnerTimer

This migrates the WebGL task timers dispatchContextLostEventTimer and restoreTimer to TaskRunnerTimer and correctly puts them in the WebGL task source.

BUG=624694
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2668573002
Cr-Commit-Position: refs/heads/master@{#447951}
Committed: https://chromium.googlesource.com/chromium/src/+/97a781d90401a977e45add57359fe5df435ee317

[Kai Ninomiya, 2017-01-30 23:50:51]

Description was changed from

==========
Migrate WebGL timers to TaskRunnerTimer

BUG=624694
==========

to

==========
Migrate WebGL timers to TaskRunnerTimer

BUG=624694
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2017-01-30 23:55:39]

Description was changed from

==========
Migrate WebGL timers to TaskRunnerTimer

BUG=624694
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Migrate WebGL timers to TaskRunnerTimer

This migrates the WebGL task timers dispatchContextLostEventTimer and
restoreTimer to TaskRunnerTimer and correctly puts them in the WebGL task
source.

BUG=624694
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2017-01-30 23:55:39]

kainino@chromium.org changed reviewers:
+ haraken@chromium.org

[Kai Ninomiya, 2017-01-30 23:56:58]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 23:57:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 02:05:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 02:05:29]

Dry run: This issue passed the CQ dry run.

[Kai Ninomiya, 2017-01-31 02:07:41]

haraken, thanks for the advice on this CL. PTAL.

zmo, kbr: FYI

[Ken Russell (switch to Gerrit), 2017-01-31 02:13:55]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2017-01-31 02:13:55]

Thanks, looks good overall. I defer to haraken's review. Please verify that the
lifetimes of all of these objects (like the execution context being extracted
from the offscreen canvas or canvas's document) are correct.

[haraken, 2017-01-31 02:24:35]

LGTM

https://codereview.chromium.org/2668573002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/TaskRunnerHelper.h (right):

https://codereview.chromium.org/2668573002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/TaskRunnerHelper.h:101: //
https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.15

// This task source is used for all tasks in the WebGL spec.

https://codereview.chromium.org/2668573002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2668573002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:1068:
RefPtr<WebTaskRunner> taskRunner,

Can you omit this parameter? You can get the task runner by calling:

  TaskRunnerHelper::get(TaskType::WebGL, &passedOffscreenCanvas->document())

[Kai Ninomiya, 2017-01-31 02:28:44]

https://codereview.chromium.org/2668573002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/TaskRunnerHelper.h (right):

https://codereview.chromium.org/2668573002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/TaskRunnerHelper.h:101: //
https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.15
On 2017/01/31 02:24:35, haraken wrote:
> 
> // This task source is used for all tasks in the WebGL spec.

Done.

https://codereview.chromium.org/2668573002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2668573002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:1068:
RefPtr<WebTaskRunner> taskRunner,
On 2017/01/31 02:24:35, haraken wrote:
> 
> Can you omit this parameter? You can get the task runner by calling:
> 
>   TaskRunnerHelper::get(TaskType::WebGL, &passedOffscreenCanvas->document())

Unfortunately it's different for the two constructors above. Whenever this
constructor is called, either passedCanvas or passedOffscreenCanvas is null, and
the other is valid.

It could all be done inline but it would have been really ugly.

[Kai Ninomiya, 2017-02-03 04:05:31]

The CQ bit was checked by kainino@chromium.org

[Kai Ninomiya, 2017-02-03 04:05:31]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2668573002/#ps20001
(title: "add comment")

[commit-bot: I haz the power, 2017-02-03 04:06:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 06:34:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486094731372780,
"parent_rev": "928bd40b6e0473422609458cffefc95a4705bfbd", "commit_rev":
"97a781d90401a977e45add57359fe5df435ee317"}

[commit-bot: I haz the power, 2017-02-03 06:35:17]

Description was changed from

==========
Migrate WebGL timers to TaskRunnerTimer

This migrates the WebGL task timers dispatchContextLostEventTimer and
restoreTimer to TaskRunnerTimer and correctly puts them in the WebGL task
source.

BUG=624694
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Migrate WebGL timers to TaskRunnerTimer

This migrates the WebGL task timers dispatchContextLostEventTimer and
restoreTimer to TaskRunnerTimer and correctly puts them in the WebGL task
source.

BUG=624694
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2668573002
Cr-Commit-Position: refs/heads/master@{#447951}
Committed:
https://chromium.googlesource.com/chromium/src/+/97a781d90401a977e45add57359f...
==========

[commit-bot: I haz the power, 2017-02-03 06:35:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/97a781d90401a977e45add57359f...