Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2668413004: [Merge to M57] ChromeOS MD: Fix cannot drag tab onto immersive fullscreen window (Closed)

Created:
3 years, 10 months ago by Qiang(Joe) Xu
Modified:
3 years, 10 months ago
Reviewers:
tdanderson, yiyix, sky
CC:
chromium-reviews, tfarina, dcheng
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Merge to M57] ChromeOS MD: Fix cannot drag tab onto immersive fullscreen window changes: This CL is a follow-up fix for https://codereview.chromium.org/2326703002/ MD change. The new MD design completely hides tabstrip without light bar anymore. In this case, we could consider tabstrip as visible. TBR=sky@chromium.org, tdanderson@chromium.org, yiyix@chromium.org BUG=676698 TEST=emulator test saw bug fixed. Review-Url: https://codereview.chromium.org/2640433004 Cr-Commit-Position: refs/heads/master@{#447658} (cherry picked from commit a4cc8622a6cca4971414a46acf812c7ea4e410eb) Review-Url: https://codereview.chromium.org/2668413004 . Cr-Commit-Position: refs/branch-heads/2987@{#263} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/b6aaac605eaec9919ecdd8d55bdb5236d546a7d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -44 lines) Patch
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 3 chunks +13 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 7 chunks +23 lines, -29 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc View 3 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 4 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Qiang(Joe) Xu
3 years, 10 months ago (2017-02-02 04:05:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b6aaac605eaec9919ecdd8d55bdb5236d546a7d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698