third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js - Issue 2668413003: DevTools: extract NetworkConditionsSelector into its own module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2668413003: DevTools: extract NetworkConditionsSelector into its own module (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/inspector.json ('K') | « third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js » ('j') | third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

index 25bef3fb4f5be772a2bacbae24dc3da401c1e396..e4b472251a47a835ed2ad4274e4e5ef3ef347565 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

@@ -973,7 +973,7 @@ Network.NetworkLogView = class extends UI.VBox {

var priority = request.initialPriority();

if (priority) {

this._suggestionBuilder.addItem(

- Network.NetworkLogView.FilterType.Priority, Components.uiLabelForPriority(priority));

+ Network.NetworkLogView.FilterType.Priority, NetworkConditions.uiLabelForPriority(priority));

}

if (request.mixedContentType !== 'none') {

@@ -1485,7 +1485,7 @@ Network.NetworkLogView = class extends UI.VBox {

return Network.NetworkLogView._requestSetCookieValueFilter.bind(null, value);

case Network.NetworkLogView.FilterType.Priority:

- return Network.NetworkLogView._requestPriorityFilter.bind(null, Components.uiLabelToPriority(value));

+ return Network.NetworkLogView._requestPriorityFilter.bind(null, NetworkConditions.uiLabelToPriority(value));

case Network.NetworkLogView.FilterType.StatusCode:

return Network.NetworkLogView._statusCodeFilter.bind(null, value);