third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js - Issue 2668413003: DevTools: extract NetworkConditionsSelector into its own module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Issue 2668413003: DevTools: extract NetworkConditionsSelector into its own module (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/inspector.json ('K') | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | third_party/WebKit/Source/devtools/front_end/network/module.json » ('j') | third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

index 92bc783dc85e750cad369f6dc11f4801c6169ae0..26747b30ec3c08b2b5f74b28dfc43631a0b75ac8 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

@@ -177,7 +177,7 @@ Network.NetworkPanel = class extends UI.Panel {

this._panelToolbar.appendSeparator();

this._panelToolbar.appendToolbarItem(this._createBlockedURLsButton());

- this._panelToolbar.appendToolbarItem(Components.NetworkConditionsSelector.createOfflineToolbarCheckbox());

+ this._panelToolbar.appendToolbarItem(NetworkConditions.NetworkConditionsSelector.createOfflineToolbarCheckbox());

this._panelToolbar.appendToolbarItem(this._createNetworkConditionsSelect());

this._panelToolbar.appendToolbarItem(new UI.ToolbarItem(this._progressBarContainer));

}

@@ -205,7 +205,7 @@ Network.NetworkPanel = class extends UI.Panel {

_createNetworkConditionsSelect() {

var toolbarItem = new UI.ToolbarComboBox(null);

toolbarItem.setMaxWidth(140);

- Components.NetworkConditionsSelector.decorateSelect(toolbarItem.selectElement());

+ NetworkConditions.NetworkConditionsSelector.decorateSelect(toolbarItem.selectElement());

return toolbarItem;

}