third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js - Issue 2668413003: DevTools: extract NetworkConditionsSelector into its own module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2668413003: DevTools: extract NetworkConditionsSelector into its own module (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/inspector.json ('K') | « third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('j') | third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

index cec8d42953cdaf88eb04bf3ac1b22172d72e9678..174969dfbad76bbf3f52d5ecd619c2cbb35c0ab7 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

@@ -373,7 +373,7 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {

var bRequest = b.requestOrFirstKnownChildRequest();

if (!aRequest || !bRequest)

return !aRequest ? -1 : 1;

- var priorityMap = Components.prioritySymbolToNumericMap();

+ var priorityMap = NetworkConditions.prioritySymbolToNumericMap();

var aPriority = aRequest.initialPriority();

var aScore = aPriority ? priorityMap.get(aPriority) : 0;

aScore = aScore || 0;

@@ -634,7 +634,7 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {

break;

case 'priority':

var priority = this._request.initialPriority();

- this._setTextAndTitle(cell, priority ? Components.uiLabelForPriority(priority) : '');

+ this._setTextAndTitle(cell, priority ? NetworkConditions.uiLabelForPriority(priority) : '');

break;

case 'connectionid':

this._setTextAndTitle(cell, this._request.connectionId);