Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2668413003: DevTools: extract NetworkConditionsSelector into its own module (Closed)

Created:
3 years, 10 months ago by chenwilliam
Modified:
3 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: extract NetworkConditionsSelector into its own module BUG=687641 Review-Url: https://codereview.chromium.org/2668413003 Cr-Commit-Position: refs/heads/master@{#448109} Committed: https://chromium.googlesource.com/chromium/src/+/8ff55ec036e5bedf34d408384ef37c0755cfcaef

Patch Set 1 #

Total comments: 5

Patch Set 2 : address CL comments #

Patch Set 3 : fix action id #

Patch Set 4 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -1410 lines) Patch
M third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt View 5 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/open-with-rendering-option-enabled-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js View 1 chunk +0 lines, -552 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/module.json View 1 2 3 3 chunks +0 lines, -35 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components/networkConditionsSettingsTab.css View 1 chunk +0 lines, -94 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/module.json View 4 chunks +26 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/externs.js View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/module.json View 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js View 1 2 12 chunks +17 lines, -288 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSettingsTab.js View 1 5 chunks +7 lines, -354 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkPriorities.js View 1 1 chunk +71 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/network_conditions/module.json View 1 2 3 3 chunks +12 lines, -37 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/network_conditions/networkConditionsSettingsTab.css View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/module.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js View 4 chunks +18 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
chenwilliam
ptal
3 years, 10 months ago (2017-02-02 02:20:03 UTC) #2
dgozman
https://codereview.chromium.org/2668413003/diff/1/third_party/WebKit/Source/devtools/front_end/inspector.json File third_party/WebKit/Source/devtools/front_end/inspector.json (right): https://codereview.chromium.org/2668413003/diff/1/third_party/WebKit/Source/devtools/front_end/inspector.json#newcode53 third_party/WebKit/Source/devtools/front_end/inspector.json:53: { "name": "network_conditions", "type": "autostart"} Should we call it ...
3 years, 10 months ago (2017-02-02 04:04:04 UTC) #3
pfeldman
> https://codereview.chromium.org/2668413003/diff/1/third_party/WebKit/Source/devtools/front_end/inspector.json#newcode53 > third_party/WebKit/Source/devtools/front_end/inspector.json:53: { "name": > "network_conditions", "type": "autostart"} > Should we call it ...
3 years, 10 months ago (2017-02-02 19:32:09 UTC) #4
chenwilliam
ptal https://codereview.chromium.org/2668413003/diff/1/third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js File third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js (right): https://codereview.chromium.org/2668413003/diff/1/third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js#newcode264 third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js:264: NetworkConditions.NetworkConditionsSettingsTab = class extends UI.VBox { On 2017/02/02 ...
3 years, 10 months ago (2017-02-02 22:26:55 UTC) #6
dgozman
lgtm
3 years, 10 months ago (2017-02-03 01:16:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668413003/40001
3 years, 10 months ago (2017-02-03 02:15:16 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/146718) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-02-03 02:18:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668413003/80001
3 years, 10 months ago (2017-02-03 21:21:29 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 23:38:35 UTC) #17
Message was sent while issue was closed. 
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8ff55ec036e5bedf34d408384ef3...

Powered by Google App Engine
This is Rietveld 408576698