third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js - Issue 2668413003: DevTools: extract NetworkConditionsSelector into its own module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

Issue 2668413003: DevTools: extract NetworkConditionsSelector into its own module (Closed)

Patch Set: rebaseline Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/networkConditionsSettingsTab.css ('k') | third_party/WebKit/Source/devtools/front_end/emulation/module.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

index 54fa80e72e892432fc029a735f7eeb4ae04d97cc..0abeced48332bc3abff2de832b704bc0f07885b6 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

@@ -178,7 +178,7 @@ Emulation.DeviceModeToolbar = class {

* @param {!UI.Toolbar} toolbar

_fillOptionsToolbar(toolbar) {

- this._networkConditionsItem = Components.NetworkConditionsSelector.createToolbarMenuButton();

+ this._networkConditionsItem = NetworkConditions.NetworkConditionsSelector.createToolbarMenuButton();

this._networkConditionsItem.setVisible(this._showNetworkConditionsSetting.get());

this._networkConditionsItem.setTitle(Common.UIString('Network throttling'));

this._networkConditionsItem.element.style.padding = '0 5px';