Issue 2668383003: Set Offline trigger delay to 1500ms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2668383003: Set Offline trigger delay to 1500ms. (Closed)

Created:
3 years, 10 months ago by Olivier

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

Set Offline trigger delay to 1500ms. Delay is too short to allow pages to load before offline page is displayed. Increase it to 1500ms, 3000ms, 4500ms to reach 25%, 50%, 75% of the load. BUG=686121 Review-Url: https://codereview.chromium.org/2663473003 Cr-Commit-Position: refs/heads/master@{#446697} (cherry picked from commit 6f74a028c85e2224bb450ef4f340dc20250cdab8) Review-Url: https://codereview.chromium.org/2668383003 . Cr-Commit-Position: refs/branch-heads/2987@{#269} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/56bd58dff5e0e7c9e921b7a0ec91c549d49eafa1

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ios/chrome/browser/reading_list/reading_list_web_state_observer.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Olivier

3 years, 10 months ago (2017-02-02 10:43:07 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
56bd58dff5e0e7c9e921b7a0ec91c549d49eafa1.