Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2663473003: Set Offline trigger delay to 1500ms. (Closed)

Created:
3 years, 10 months ago by Olivier
Modified:
3 years, 10 months ago
Reviewers:
jif
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set Offline trigger delay to 1500ms. Delay is too short to allow pages to load before offline page is displayed. Increase it to 1500ms, 3000ms, 4500ms to reach 25%, 50%, 75% of the load. BUG=686121 Review-Url: https://codereview.chromium.org/2663473003 Cr-Commit-Position: refs/heads/master@{#446697} Committed: https://chromium.googlesource.com/chromium/src/+/6f74a028c85e2224bb450ef4f340dc20250cdab8

Patch Set 1 #

Patch Set 2 : fix case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/chrome/browser/reading_list/reading_list_web_state_observer.mm View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Olivier
3 years, 10 months ago (2017-01-27 16:52:45 UTC) #3
jif
lgtm
3 years, 10 months ago (2017-01-27 16:55:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663473003/20001
3 years, 10 months ago (2017-01-27 16:58:29 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 17:08:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6f74a028c85e2224bb450ef4f340...

Powered by Google App Engine
This is Rietveld 408576698