Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2668323002: [Sync] Only get bridge on model thread for ModelTypeController. (Closed)

Created:
3 years, 10 months ago by skym
Modified:
3 years, 10 months ago
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Only get bridge on model thread for ModelTypeController. AutocompleteSyncBridge cannot be fetched on the UI thread, because of the way AutofillWebDataService provides it. This can only be done on the model thread. Previously the ModelTypeController was updated to mostly respect this in https://codereview.chromium.org/2508263003/ . However, we seem to have missed the DisableSync() case. This CL copies the existing pattern for this scenario. BUG=686172 Review-Url: https://codereview.chromium.org/2668323002 Cr-Commit-Position: refs/heads/master@{#447779} Committed: https://chromium.googlesource.com/chromium/src/+/c3389b63ea8217144db344e29451b9ee3bbd05e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M components/sync/driver/model_type_controller.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (12 generated)
skym
PTAL
3 years, 10 months ago (2017-02-01 20:16:45 UTC) #7
Patrick Noland
lgtm
3 years, 10 months ago (2017-02-01 22:46:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668323002/1
3 years, 10 months ago (2017-02-02 16:42:29 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-02 16:42:31 UTC) #12
skym
PTAL Max
3 years, 10 months ago (2017-02-02 16:44:04 UTC) #14
maxbogue
lgtm
3 years, 10 months ago (2017-02-02 16:48:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668323002/1
3 years, 10 months ago (2017-02-02 16:49:56 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 16:58:19 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c3389b63ea8217144db344e29451...

Powered by Google App Engine
This is Rietveld 408576698