[Sync] Incorporate value into USS AUTOFILL non_unique_name.

[Sync] Incorporate value into USS AUTOFILL non_unique_name.

The directory based AUTOFILL implemented used to set
autofill_entry|name|value as the non_unique_name. During the USS
rewrite this was changed to just be the name of the form field. This is
less helpful when looking at sync-internals, you may have many entries
for the same form with different values. It would be nice if this name
distinguished them.

Thinking about the cost of increasing non_unique_name values, it
directly impacts bandwidth usage, being part of commits and GUs, though
it does get compressed. We don't seem to keep this value in memory at
runtime when steady state, which is really the most important scenario.

BUG=686172
Review-Url: https://codereview.chromium.org/2663423002
Cr-Commit-Position: refs/heads/master@{#447776}
Committed: https://chromium.googlesource.com/chromium/src/+/08754c122f848c02be04f9858a623ec706fbca34

[skym, 2017-02-01 17:11:50]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 17:11:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 18:00:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 18:00:56]

Dry run: This issue passed the CQ dry run.

[skym, 2017-02-01 20:11:35]

Description was changed from

==========
[Sync] Incorporate value into USS AUTOFILL non_unique_name.

BUG=686172
==========

to

==========
[Sync] Incorporate value into USS AUTOFILL non_unique_name.

The directory based AUTOFILL implemented used to set
autofill_entry|name|value as the non_unique_name. During the USS
rewrite this was changed to just be the name of the form field. This is
less helpful when looking at sync-internals, you may have many entries
for the same form with different values. It would be nice if this name
distinguished them.

Thinking about the cost of increasing non_unique_name values, it
directly impacts bandwidth usage, being part of commits and GUs, though
it does get compressed. We don't seem to keep this value in memory at
runtime when steady state, which is really the most important scenario.

BUG=686172
==========

[skym, 2017-02-01 20:11:35]

skym@chromium.org changed reviewers:
+ pavely@chromium.org

[skym, 2017-02-01 20:11:51]

PTAL, tiny change that we've already talked about in person.

[pavely, 2017-02-01 23:59:26]

lgtm

[skym, 2017-02-02 00:03:17]

skym@chromium.org changed reviewers:
+ mathp@chromium.org

[skym, 2017-02-02 00:03:17]

Adding mathp as autofill owner. PTAL

[Mathieu, 2017-02-02 01:41:14]

lgtm

[skym, 2017-02-02 16:32:20]

The CQ bit was checked by skym@chromium.org

[commit-bot: I haz the power, 2017-02-02 16:32:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 16:38:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486053140318490, "parent_rev":
"392b8a585288a538906babd6a2122fa58038b031", "commit_rev":
"08754c122f848c02be04f9858a623ec706fbca34"}

[commit-bot: I haz the power, 2017-02-02 16:40:42]

Description was changed from

==========
[Sync] Incorporate value into USS AUTOFILL non_unique_name.

The directory based AUTOFILL implemented used to set
autofill_entry|name|value as the non_unique_name. During the USS
rewrite this was changed to just be the name of the form field. This is
less helpful when looking at sync-internals, you may have many entries
for the same form with different values. It would be nice if this name
distinguished them.

Thinking about the cost of increasing non_unique_name values, it
directly impacts bandwidth usage, being part of commits and GUs, though
it does get compressed. We don't seem to keep this value in memory at
runtime when steady state, which is really the most important scenario.

BUG=686172
==========

to

==========
[Sync] Incorporate value into USS AUTOFILL non_unique_name.

The directory based AUTOFILL implemented used to set
autofill_entry|name|value as the non_unique_name. During the USS
rewrite this was changed to just be the name of the form field. This is
less helpful when looking at sync-internals, you may have many entries
for the same form with different values. It would be nice if this name
distinguished them.

Thinking about the cost of increasing non_unique_name values, it
directly impacts bandwidth usage, being part of commits and GUs, though
it does get compressed. We don't seem to keep this value in memory at
runtime when steady state, which is really the most important scenario.

BUG=686172

Review-Url: https://codereview.chromium.org/2663423002
Cr-Commit-Position: refs/heads/master@{#447776}
Committed:
https://chromium.googlesource.com/chromium/src/+/08754c122f848c02be04f9858a62...
==========

[commit-bot: I haz the power, 2017-02-02 16:40:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/08754c122f848c02be04f9858a62...