Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2668143003: Revert of Implements CSSPropertyAPI for the margin properties. (Closed)

Created:
3 years, 10 months ago by tsergeant
Modified:
3 years, 10 months ago
Reviewers:
sashab, aazzam
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implements CSSPropertyAPI for the margin properties. (patchset #4 id:60001 of https://codereview.chromium.org/2648703002/ ) Reason for revert: conflict with patch landed at the same time Original issue's description: > Implements CSSPropertyAPI for the margin properties. > > A part of Project Ribbon, separating the parsing logic for CSS > properties from the parser into an API. This patch removes > CSSPropertyMargin{Top,Right,Bottom,Left}, > CSSProperty{Top,Right,Bottom,Left}, and > CSSPropertyWebkitMargin[Top|Right|Bottom|Left] from the switch statement > in parseSingleValue, and calls the API instead. > > A function pointer to the parseSingleValue function from the API for the > margin properties is stored in a CSSPropertyDescriptor, and is > called from CSSPropertyParser. > > This patch: > - Adds CSSPropertyAPIMargin.cpp and CSSPropertyAPIWebkitMargin.cpp to > the BUILD.gn file. > - Adds api_class=CSSPropertyAPIMargin and > api_class=CSSPropertyAPIWebkitMargin flag in CSSProperties.in to each > of the margin and -webkit-margin properties respectively, which > indicates that CSSPropertyAPIMargin.h and CSSPropertyWebkitMargin.h > are generated. > - Moves the parsing logic for radius from CSSPropertyParser.cpp > to CSSPropertyAPI[Webkit]Margin.cpp, which implements CSSPropertyAPI.h. > > BUG=668012 > > Review-Url: https://codereview.chromium.org/2648703002 > Cr-Commit-Position: refs/heads/master@{#447430} > Committed: https://chromium.googlesource.com/chromium/src/+/72f22e3a5858ab9593cea5703c840b8f3c60327c TBR=sashab@chromium.org,aazzam@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=668012 Review-Url: https://codereview.chromium.org/2668143003 Cr-Commit-Position: refs/heads/master@{#447435} Committed: https://chromium.googlesource.com/chromium/src/+/ec3068b496096f9eee0d3718a2d16de374c9f9d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -54 lines) Patch
M third_party/WebKit/Source/core/css/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 6 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMargin.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitMargin.cpp View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
tsergeant
Created Revert of Implements CSSPropertyAPI for the margin properties.
3 years, 10 months ago (2017-02-01 03:11:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668143003/1
3 years, 10 months ago (2017-02-01 03:11:50 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 03:16:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ec3068b496096f9eee0d3718a2d1...

Powered by Google App Engine
This is Rietveld 408576698