DescriptionRevert of Implements CSSPropertyAPI for the margin properties. (patchset #4 id:60001 of https://codereview.chromium.org/2648703002/ )
Reason for revert:
conflict with patch landed at the same time
Original issue's description:
> Implements CSSPropertyAPI for the margin properties.
>
> A part of Project Ribbon, separating the parsing logic for CSS
> properties from the parser into an API. This patch removes
> CSSPropertyMargin{Top,Right,Bottom,Left},
> CSSProperty{Top,Right,Bottom,Left}, and
> CSSPropertyWebkitMargin[Top|Right|Bottom|Left] from the switch statement
> in parseSingleValue, and calls the API instead.
>
> A function pointer to the parseSingleValue function from the API for the
> margin properties is stored in a CSSPropertyDescriptor, and is
> called from CSSPropertyParser.
>
> This patch:
> - Adds CSSPropertyAPIMargin.cpp and CSSPropertyAPIWebkitMargin.cpp to
> the BUILD.gn file.
> - Adds api_class=CSSPropertyAPIMargin and
> api_class=CSSPropertyAPIWebkitMargin flag in CSSProperties.in to each
> of the margin and -webkit-margin properties respectively, which
> indicates that CSSPropertyAPIMargin.h and CSSPropertyWebkitMargin.h
> are generated.
> - Moves the parsing logic for radius from CSSPropertyParser.cpp
> to CSSPropertyAPI[Webkit]Margin.cpp, which implements CSSPropertyAPI.h.
>
> BUG=668012
>
> Review-Url: https://codereview.chromium.org/2648703002
> Cr-Commit-Position: refs/heads/master@{#447430}
> Committed: https://chromium.googlesource.com/chromium/src/+/72f22e3a5858ab9593cea5703c840b8f3c60327c
TBR=sashab@chromium.org,aazzam@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668012
Review-Url: https://codereview.chromium.org/2668143003
Cr-Commit-Position: refs/heads/master@{#447435}
Committed: https://chromium.googlesource.com/chromium/src/+/ec3068b496096f9eee0d3718a2d16de374c9f9d6
Patch Set 1 #
Messages
Total messages: 8 (5 generated)
|