Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2668113003: Gtk3: Let NativeThemeBase render arrows on scrollbar buttons (Closed)

Created:
3 years, 10 months ago by Tom (Use chromium acct)
Modified:
3 years, 10 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk3: Let NativeThemeBase render arrows on scrollbar buttons GtkArrow was deprecated in Gtk 3.14, which was causing a compile failure when using the Jessie sysroot. This CL removes Gtk-rendering of the arrows and instead lets NativeThemeBase take care of it. R=erg@chromium.org BUG=132847 Review-Url: https://codereview.chromium.org/2668113003 Cr-Commit-Position: refs/heads/master@{#447599} Committed: https://chromium.googlesource.com/chromium/src/+/999a293f38ec8b6b16dba3dfbf5aa3dd1c9673a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -25 lines) Patch
M chrome/browser/ui/libgtkui/native_theme_gtk3.cc View 3 chunks +7 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom (Use chromium acct)
erg@ PTAL We'll probably want to add gtk_render_arrow back at some point, but this at ...
3 years, 10 months ago (2017-02-01 19:57:43 UTC) #1
Elliot Glaysher
lgtm as a temporary build fix
3 years, 10 months ago (2017-02-01 20:32:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668113003/1
3 years, 10 months ago (2017-02-01 20:33:15 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 20:43:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/999a293f38ec8b6b16dba3dfbf5a...

Powered by Google App Engine
This is Rietveld 408576698