Gtk3: Let NativeThemeBase render arrows on scrollbar buttons

chrome/browser/ui/libgtkui/native_theme_gtk3.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/libgtkui/native_theme_gtk3.h"
 
 #include <gtk/gtk.h>
 
 #include "chrome/browser/ui/libgtkui/chrome_gtk_frame.h"
 #include "chrome/browser/ui/libgtkui/chrome_gtk_menu_subclasses.h"
@@ skipping 342 matching lines @@
   g_type_class_unref(g_type_class_ref(gtk_menu_get_type()));
   g_type_class_unref(g_type_class_ref(gtk_menu_item_get_type()));
   g_type_class_unref(g_type_class_ref(gtk_entry_get_type()));
   g_type_class_unref(g_type_class_ref(gtk_info_bar_get_type()));
   g_type_class_unref(g_type_class_ref(gtk_tooltip_get_type()));
   g_type_class_unref(g_type_class_ref(gtk_scrollbar_get_type()));
   g_type_class_unref(g_type_class_ref(gtk_toolbar_get_type()));
   g_type_class_unref(g_type_class_ref(gtk_text_view_get_type()));
   g_type_class_unref(g_type_class_ref(gtk_separator_get_type()));
   g_type_class_unref(g_type_class_ref(gtk_menu_bar_get_type()));
-  g_type_class_unref(g_type_class_ref(gtk_arrow_get_type()));
   g_type_class_unref(g_type_class_ref(gtk_scrolled_window_get_type()));
   g_type_class_unref(g_type_class_ref(gtk_range_get_type()));
 
   g_signal_connect_after(gtk_settings_get_default(), "notify::gtk-theme-name",
                          G_CALLBACK(OnThemeChanged), this);
 }
 
 // This doesn't actually get called
 NativeThemeGtk3::~NativeThemeGtk3() {}
 
@@ skipping 14 matching lines @@
 void NativeThemeGtk3::PaintArrowButton(SkCanvas* canvas,
                                        const gfx::Rect& rect,
                                        Part direction,
                                        State state) const {
   auto context = GetStyleContextFromCss(
       GtkVersionCheck(3, 20)
           ? "GtkScrollbar#scrollbar #contents GtkButton#button"
           : "GtkRange.scrollbar.button");
   GtkStateFlags state_flags = StateToStateFlags(state);
   gtk_style_context_set_state(context, state_flags);
-  SkBitmap bitmap =
-      GetWidgetBitmap(rect.size(), context, BG_RENDER_NORMAL, true);
 
-  gdouble angle = 0;
   switch (direction) {
     case kScrollbarUpArrow:
-      angle = 0;
       gtk_style_context_add_class(context, GTK_STYLE_CLASS_TOP);
       break;
     case kScrollbarRightArrow:
-      angle = G_PI / 2;
       gtk_style_context_add_class(context, GTK_STYLE_CLASS_RIGHT);
       break;
     case kScrollbarDownArrow:
-      angle = G_PI;
       gtk_style_context_add_class(context, GTK_STYLE_CLASS_BOTTOM);
       break;
     case kScrollbarLeftArrow:
-      angle = 3 * G_PI / 2;
       gtk_style_context_add_class(context, GTK_STYLE_CLASS_LEFT);
       break;
     default:
       NOTREACHED();
   }
 
-  CairoSurface surface(bitmap);
-
-  auto arrow_context = AppendCssNodeToStyleContext(context, "GtkArrow#arrow");
-  gfloat arrow_scaling = 0.7;  // Default scaling for a GtkArrow
-  gtk_style_context_get_style(arrow_context, "arrow-scaling", &arrow_scaling,
-                              nullptr);
-  const double w = rect.width();
-  const double h = rect.height();
-  const double arrow_size = std::min(w, h) * arrow_scaling;
-  gtk_render_arrow(arrow_context, surface.cairo(), angle, (w - arrow_size) / 2,
-                   (h - arrow_size) / 2, arrow_size);
-  canvas->drawBitmap(bitmap, rect.x(), rect.y());
+  PaintWidget(canvas, rect, context, BG_RENDER_NORMAL, true);
+  PaintArrow(canvas, rect, direction, SkColorFromStyleContext(context));
 }
 
 void NativeThemeGtk3::PaintScrollbarTrack(
     SkCanvas* canvas,
     Part part,
     State state,
     const ScrollbarTrackExtraParams& extra_params,
     const gfx::Rect& rect) const {
-  PaintWidget(canvas, rect,
-              GetStyleContextFromCss(GtkVersionCheck(3, 20)
-                  ? "GtkScrollbar#scrollbar #contents #trough"
-                  : "GtkScrollbar.scrollbar.trough"),
-                  BG_RENDER_NORMAL,true);
+  PaintWidget(canvas, rect, GetStyleContextFromCss(
+                                GtkVersionCheck(3, 20)
+                                    ? "GtkScrollbar#scrollbar #contents #trough"
+                                    : "GtkScrollbar.scrollbar.trough"),
+              BG_RENDER_NORMAL, true);
 }
 
 void NativeThemeGtk3::PaintScrollbarThumb(
     SkCanvas* canvas,
     Part part,
     State state,
     const gfx::Rect& rect,
     NativeTheme::ScrollbarOverlayColorTheme theme) const {
   auto context = GetStyleContextFromCss(
       GtkVersionCheck(3, 20)
@@ skipping 106 matching lines @@
 
   if (frame_top_area.incognito) {
     bitmap = SkBitmapOperations::CreateHSLShiftedBitmap(
         bitmap, kDefaultTintFrameIncognito);
   }
 
   canvas->drawBitmap(bitmap, rect.x(), rect.y());
 }
 
 }  // namespace libgtkui