VrShell background implemented in JS.

VrShell background implemented in JS.

- Added fill attribute to JS API so that you can also set a gradient for the objects filling instead of a sprite.
- Adapted native code accordingly.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2668093002
Cr-Commit-Position: refs/heads/master@{#448280}
Committed: https://chromium.googlesource.com/chromium/src/+/1362193151001d9c269c705c9881db89e6cf8c64

[tiborg1, 2017-01-31 20:04:19]

Description was changed from

==========
VrShell background implemented in JS.

- Added fill attribute to JS API so that you can also set a gradient for the
objects filling instead of a sprite.
- Adapted native code accordingly.
==========

to

==========
VrShell background implemented in JS.

- Added fill attribute to JS API so that you can also set a gradient for the
objects filling instead of a sprite.
- Adapted native code accordingly.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[mthiesse, 2017-01-31 20:54:53]

mthiesse@chromium.org changed reviewers:
+ mthiesse@chromium.org

[mthiesse, 2017-01-31 20:54:54]

Seems okay from a high level. We want to be careful about how much complexity we
add to the API, so a simple two-color gradient for the huge background seems
fine because of the memory/quality wins, but we should avoid anything more
complex than that. (anything more complex should be done in html/css)

https://codereview.chromium.org/2668093002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell_gl.cc (right):

https://codereview.chromium.org/2668093002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:817: } break;
nit: break; should go inside braces.

https://codereview.chromium.org/2668093002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:822: transform,
rect->center_color, rect->edge_color);
Should this not respect opacity?

https://codereview.chromium.org/2668093002/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):

https://codereview.chromium.org/2668093002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:508: 
nit: whitespace here and below

https://codereview.chromium.org/2668093002/diff/1/ios/chrome/browser/about_fl...
File ios/chrome/browser/about_flags.mm (left):

https://codereview.chromium.org/2668093002/diff/1/ios/chrome/browser/about_fl...
ios/chrome/browser/about_flags.mm:41: #endif
was this intentional?

[tiborg1, 2017-02-01 00:22:17]

tiborg@google.com changed reviewers:
+ cjgrant@chromium.org

[tiborg1, 2017-02-01 00:22:18]

https://codereview.chromium.org/2668093002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell_gl.cc (right):

https://codereview.chromium.org/2668093002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:817: } break;
On 2017/01/31 20:54:54, mthiesse wrote:
> nit: break; should go inside braces.

Done.

https://codereview.chromium.org/2668093002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:822: transform,
rect->center_color, rect->edge_color);
On 2017/01/31 20:54:54, mthiesse wrote:
> Should this not respect opacity?

Good point! It's fixed.

https://codereview.chromium.org/2668093002/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):

https://codereview.chromium.org/2668093002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:508: 
On 2017/01/31 20:54:54, mthiesse wrote:
> nit: whitespace here and below

Done.

https://codereview.chromium.org/2668093002/diff/1/ios/chrome/browser/about_fl...
File ios/chrome/browser/about_flags.mm (left):

https://codereview.chromium.org/2668093002/diff/1/ios/chrome/browser/about_fl...
ios/chrome/browser/about_flags.mm:41: #endif
On 2017/01/31 20:54:54, mthiesse wrote:
> was this intentional?

Oops, no this was not intentional. I don't know how this happened.

[cjgrant, 2017-02-01 14:36:40]

https://codereview.chromium.org/2668093002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene.cc (right):

https://codereview.chromium.org/2668093002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene.cc:425: // Parse the element fill.
ui_scene_unittest.cc should be updated to cover the changes to this file.

nice ninja -C <obj-dir> -j500 -l32 vr_shell_unittests && \
<obj-dir>/bin/run_vr_shell_unittests -d <device-id>

https://codereview.chromium.org/2668093002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene.cc:439: ParseColorf(dict,
"centerColor", &element->center_color);
Missing break here?

https://codereview.chromium.org/2668093002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_math.h (right):

https://codereview.chromium.org/2668093002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_math.h:37: typedef struct Colorf {
Is there a GL or gfx:: struct we could use instead, or do you prefer not?

[cjgrant, 2017-02-01 14:45:19]

On 2017/01/31 20:54:54, mthiesse wrote:
> Seems okay from a high level. We want to be careful about how much complexity
we
> add to the API, so a simple two-color gradient for the huge background seems
> fine because of the memory/quality wins, but we should avoid anything more
> complex than that. (anything more complex should be done in html/css)

+1 on API complexity, as discussed.  My preference is still for a tighter
setBackgroundParameters(colors, spacing, transition-time) API, which we'd
generalize if there becomes a need.  But lets see how this pans out (ie. LTGM as
is).

[tiborg1, 2017-02-01 20:38:58]

https://codereview.chromium.org/2668093002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene.cc (right):

https://codereview.chromium.org/2668093002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene.cc:425: // Parse the element fill.
On 2017/02/01 14:36:40, cjgrant wrote:
> ui_scene_unittest.cc should be updated to cover the changes to this file.
> 
> nice ninja -C <obj-dir> -j500 -l32 vr_shell_unittests && \
> <obj-dir>/bin/run_vr_shell_unittests -d <device-id>

Good point! Done.

https://codereview.chromium.org/2668093002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene.cc:439: ParseColorf(dict,
"centerColor", &element->center_color);
On 2017/02/01 14:36:40, cjgrant wrote:
> Missing break here?

Done.

https://codereview.chromium.org/2668093002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_math.h (right):

https://codereview.chromium.org/2668093002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_math.h:37: typedef struct Colorf {
On 2017/02/01 14:36:40, cjgrant wrote:
> Is there a GL or gfx:: struct we could use instead, or do you prefer not?

So, gfx uses SkColor, which is a 32 bit integer. This would make the parsing and
the passing to GL a bit more difficult. Do you think it's worth it? There is no
GL struct that I know of.

[cjgrant, 2017-02-02 14:48:26]

A few more things, then I think we're good to go.

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_elements.h (right):

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_elements.h:36: // The element is the content
quad. Only one content quad may be added to the
If commenting the type, please comment the others as well (other than NONE :).

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_elements.h:135: unsigned int tile_number;
tile_number is confusing to me - like it's a sprite or texture number.  I think
num_gridlines or gridline_count would be more clear.

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene.cc (right):

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene.cc:445: dict.GetInteger("tileNumber",
&value);
- This code is setting tile_number to a random value if not in the dictionary -
it should be CHECK()ing.
- Why not read directly into element->tile_number?  If it's because of the
unsigned type mismatch, the lets just make tile_number an int.

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene_unittest.cc (right):

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_unittest.cc:315: constexpr double
EPSILON = 0.000001;
This can be removed (see below).

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_unittest.cc:358:
EXPECT_NEAR(element->edge_color.r, 0.1, EPSILON);
I think you want EXPECT_FLOAT_EQ() for these cases, as in the other test cases.

[tiborg1, 2017-02-02 16:52:27]

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_elements.h (right):

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_elements.h:36: // The element is the content
quad. Only one content quad may be added to the
On 2017/02/02 14:48:25, cjgrant wrote:
> If commenting the type, please comment the others as well (other than NONE :).

Good point. Done.

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_elements.h:135: unsigned int tile_number;
On 2017/02/02 14:48:25, cjgrant wrote:
> tile_number is confusing to me - like it's a sprite or texture number.  I
think
> num_gridlines or gridline_count would be more clear.
> 

Done.

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene.cc (right):

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene.cc:445: dict.GetInteger("tileNumber",
&value);
On 2017/02/02 14:48:25, cjgrant wrote:
> - This code is setting tile_number to a random value if not in the dictionary
-
> it should be CHECK()ing.
> - Why not read directly into element->tile_number?  If it's because of the
> unsigned type mismatch, the lets just make tile_number an int.

Good call! I changed tile number to unsigned since there was another error
because of unsigned-signed integer comparison. Since tile number / gridline
count cannot reasonably be negative, I thought unsigned would be the better
choice here. But it makes the code handling more complicated. So, it's signed
again with a check so that it is never negative.

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene_unittest.cc (right):

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_unittest.cc:315: constexpr double
EPSILON = 0.000001;
On 2017/02/02 14:48:25, cjgrant wrote:
> This can be removed (see below).

Done.

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_unittest.cc:358:
EXPECT_NEAR(element->edge_color.r, 0.1, EPSILON);
On 2017/02/02 14:48:25, cjgrant wrote:
> I think you want EXPECT_FLOAT_EQ() for these cases, as in the other test
cases.

Oh yes, this makes it way more elegant :) Done.

[cjgrant, 2017-02-03 15:58:29]

lgtm after one last edit (see comment).

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene.cc (right):

https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene.cc:445: dict.GetInteger("tileNumber",
&value);
On 2017/02/02 16:52:27, tiborg wrote:
> On 2017/02/02 14:48:25, cjgrant wrote:
> > - This code is setting tile_number to a random value if not in the
dictionary
> -
> > it should be CHECK()ing.
> > - Why not read directly into element->tile_number?  If it's because of the
> > unsigned type mismatch, the lets just make tile_number an int.
> 
> Good call! I changed tile number to unsigned since there was another error
> because of unsigned-signed integer comparison. Since tile number / gridline
> count cannot reasonably be negative, I thought unsigned would be the better
> choice here. But it makes the code handling more complicated. So, it's signed
> again with a check so that it is never negative.

We should also check that the read from the dictionary got a value (so keep the
existing check, and add a new one on the previous line).

[tiborg1, 2017-02-03 16:50:50]

On 2017/02/03 15:58:29, cjgrant wrote:
> lgtm after one last edit (see comment).
> 
>
https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
> File chrome/browser/android/vr_shell/ui_scene.cc (right):
> 
>
https://codereview.chromium.org/2668093002/diff/60001/chrome/browser/android/...
> chrome/browser/android/vr_shell/ui_scene.cc:445: dict.GetInteger("tileNumber",
> &value);
> On 2017/02/02 16:52:27, tiborg wrote:
> > On 2017/02/02 14:48:25, cjgrant wrote:
> > > - This code is setting tile_number to a random value if not in the
> dictionary
> > -
> > > it should be CHECK()ing.
> > > - Why not read directly into element->tile_number?  If it's because of the
> > > unsigned type mismatch, the lets just make tile_number an int.
> > 
> > Good call! I changed tile number to unsigned since there was another error
> > because of unsigned-signed integer comparison. Since tile number / gridline
> > count cannot reasonably be negative, I thought unsigned would be the better
> > choice here. But it makes the code handling more complicated. So, it's
signed
> > again with a check so that it is never negative.
> 
> We should also check that the read from the dictionary got a value (so keep
the
> existing check, and add a new one on the previous line).

Added checking for all fill types.

[tiborg1, 2017-02-03 16:50:59]

The CQ bit was checked by tiborg@google.com

[tiborg1, 2017-02-03 16:50:59]

The patchset sent to the CQ was uploaded after l-g-t-m from cjgrant@chromium.org
Link to the patchset: https://codereview.chromium.org/2668093002/#ps100001
(title: "Added checking")

[commit-bot: I haz the power, 2017-02-03 16:51:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 16:51:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 16:51:16]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[mthiesse, 2017-02-03 16:59:27]

lgtm. Not sure why Chris' lgtm doesn't count here... it should.

[tiborg1, 2017-02-03 17:45:20]

The CQ bit was checked by tiborg@google.com

[commit-bot: I haz the power, 2017-02-03 17:45:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 17:48:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 17:48:08]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tiborg1, 2017-02-03 17:53:19]

The CQ bit was checked by tiborg@google.com

[tiborg1, 2017-02-03 17:53:36]

The CQ bit was unchecked by tiborg@google.com

[commit-bot: I haz the power, 2017-02-03 17:53:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tiborg1, 2017-02-03 17:53:57]

The CQ bit was checked by tiborg@google.com to run a CQ dry run

[tiborg1, 2017-02-03 17:54:52]

The CQ bit was unchecked by tiborg@google.com

[tiborg1, 2017-02-03 17:54:53]

The CQ bit was checked by tiborg@google.com

[commit-bot: I haz the power, 2017-02-03 17:54:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tiborg1, 2017-02-03 18:03:33]

The CQ bit was checked by tiborg@google.com

[tiborg1, 2017-02-03 18:03:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org, cjgrant@chromium.org
Link to the patchset: https://codereview.chromium.org/2668093002/#ps120001
(title: "gclient sync")

[commit-bot: I haz the power, 2017-02-03 18:04:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 18:08:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 18:08:03]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[tiborg1, 2017-02-03 20:38:01]

The CQ bit was checked by tiborg@google.com

[tiborg1, 2017-02-03 20:38:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org, cjgrant@chromium.org
Link to the patchset: https://codereview.chromium.org/2668093002/#ps180001
(title: "Removed new line")

[commit-bot: I haz the power, 2017-02-03 20:38:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 22:04:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 22:04:25]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[tiborg1, 2017-02-04 02:53:28]

The CQ bit was checked by tiborg@google.com

[tiborg1, 2017-02-04 02:53:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org, cjgrant@chromium.org
Link to the patchset: https://codereview.chromium.org/2668093002/#ps200001
(title: "Fixed tests")

[commit-bot: I haz the power, 2017-02-04 02:53:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 04:54:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 04:54:42]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_TIMED_OUT,
no build URL)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no
build URL)
  win_clang on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)

[tiborg1, 2017-02-06 16:15:08]

The CQ bit was checked by tiborg@google.com

[commit-bot: I haz the power, 2017-02-06 16:15:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 17:14:41]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1486397708381800,
"parent_rev": "26db3243b81298e511988a3a7c1f88ba165dbfa8", "commit_rev":
"1362193151001d9c269c705c9881db89e6cf8c64"}

[commit-bot: I haz the power, 2017-02-06 17:15:38]

Description was changed from

==========
VrShell background implemented in JS.

- Added fill attribute to JS API so that you can also set a gradient for the
objects filling instead of a sprite.
- Adapted native code accordingly.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
VrShell background implemented in JS.

- Added fill attribute to JS API so that you can also set a gradient for the
objects filling instead of a sprite.
- Adapted native code accordingly.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2668093002
Cr-Commit-Position: refs/heads/master@{#448280}
Committed:
https://chromium.googlesource.com/chromium/src/+/1362193151001d9c269c705c9881...
==========

[commit-bot: I haz the power, 2017-02-06 17:15:40]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/1362193151001d9c269c705c9881...