Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 2668053004: Revert of [Turbofan] Macro-ize instruction selection for x64. (Closed)

Created:
3 years, 10 months ago by bbudge
Modified:
3 years, 10 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Turbofan] Macro-ize instruction selection for x64. (patchset #1 id:1 of https://codereview.chromium.org/2668753004/ ) Reason for revert: Breaks array_concat Original issue's description: > [Turbofan] Macro-ize instruction selection for x64. > - Uses macros to reduce code duplication. > - Uses calls to VisitRO and VisitRR to reduce code bloat. > > LOG=N > BUG=v8:4124 > > Review-Url: https://codereview.chromium.org/2668753004 > Cr-Commit-Position: refs/heads/master@{#42828} > Committed: https://chromium.googlesource.com/v8/v8/+/e8e2e3c826d42490f809e1c45750bbb438b60d8c TBR=titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Review-Url: https://codereview.chromium.org/2668053004 Cr-Commit-Position: refs/heads/master@{#42831} Committed: https://chromium.googlesource.com/v8/v8/+/f328f3e50e9f7f42433bb2070d08c8c4dfc5d032

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -55 lines) Patch
M src/compiler/x64/instruction-selector-x64.cc View 10 chunks +212 lines, -55 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
bbudge
Created Revert of [Turbofan] Macro-ize instruction selection for x64.
3 years, 10 months ago (2017-02-01 02:53:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668053004/1
3 years, 10 months ago (2017-02-01 02:53:07 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 02:53:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f328f3e50e9f7f42433bb2070d08c8c4dfc...

Powered by Google App Engine
This is Rietveld 408576698