Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2668753004:
[Turbofan] Macro-ize instruction selection for x64. (Closed)
Description[Turbofan] Macro-ize instruction selection for x64.
- Uses macros to reduce code duplication.
- Uses calls to VisitRO and VisitRR to reduce code bloat.
LOG=N
BUG=v8:4124
Review-Url: https://codereview.chromium.org/2668753004
Cr-Original-Commit-Position: refs/heads/master@{#42828}
Committed: https://chromium.googlesource.com/v8/v8/+/e8e2e3c826d42490f809e1c45750bbb438b60d8c
Review-Url: https://codereview.chromium.org/2668753004
Cr-Commit-Position: refs/heads/master@{#42862}
Committed: https://chromium.googlesource.com/v8/v8/+/d8ab932ceb3b906f36ab3216f84d8e626b3e5a5e
Patch Set 1 #Patch Set 2 : VisitFloat64SilenceNaN is not VisitRO. #Messages
Total messages: 24 (17 generated)
The CQ bit was checked by bbudge@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bbudge@chromium.org changed reviewers: + titzer@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by bbudge@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485914016159650, "parent_rev":
"d08fd93ba6d9ffeba21c76601f75c5ffa4eb9d38", "commit_rev":
"e8e2e3c826d42490f809e1c45750bbb438b60d8c"}
Message was sent while issue was closed.
Description was changed from ========== [Turbofan] Macro-ize instruction selection for x64. - Uses macros to reduce code duplication. - Uses calls to VisitRO and VisitRR to reduce code bloat. LOG=N BUG=v8:4124 ========== to ========== [Turbofan] Macro-ize instruction selection for x64. - Uses macros to reduce code duplication. - Uses calls to VisitRO and VisitRR to reduce code bloat. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2668753004 Cr-Commit-Position: refs/heads/master@{#42828} Committed: https://chromium.googlesource.com/v8/v8/+/e8e2e3c826d42490f809e1c45750bbb438b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/e8e2e3c826d42490f809e1c45750bbb438b...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2668053004/ by bbudge@chromium.org. The reason for reverting is: Breaks array_concat.
Message was sent while issue was closed.
Description was changed from ========== [Turbofan] Macro-ize instruction selection for x64. - Uses macros to reduce code duplication. - Uses calls to VisitRO and VisitRR to reduce code bloat. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2668753004 Cr-Commit-Position: refs/heads/master@{#42828} Committed: https://chromium.googlesource.com/v8/v8/+/e8e2e3c826d42490f809e1c45750bbb438b... ========== to ========== [Turbofan] Macro-ize instruction selection for x64. - Uses macros to reduce code duplication. - Uses calls to VisitRO and VisitRR to reduce code bloat. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2668753004 Cr-Commit-Position: refs/heads/master@{#42828} Committed: https://chromium.googlesource.com/v8/v8/+/e8e2e3c826d42490f809e1c45750bbb438b... ==========
The CQ bit was checked by bbudge@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bbudge@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org Link to the patchset: https://codereview.chromium.org/2668753004/#ps20001 (title: "VisitFloat64SilenceNaN is not VisitRO.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485968459954060,
"parent_rev": "59b8496c81eda6da774af2991a8cf641797a754e", "commit_rev":
"d8ab932ceb3b906f36ab3216f84d8e626b3e5a5e"}
Message was sent while issue was closed.
Description was changed from ========== [Turbofan] Macro-ize instruction selection for x64. - Uses macros to reduce code duplication. - Uses calls to VisitRO and VisitRR to reduce code bloat. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2668753004 Cr-Commit-Position: refs/heads/master@{#42828} Committed: https://chromium.googlesource.com/v8/v8/+/e8e2e3c826d42490f809e1c45750bbb438b... ========== to ========== [Turbofan] Macro-ize instruction selection for x64. - Uses macros to reduce code duplication. - Uses calls to VisitRO and VisitRR to reduce code bloat. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2668753004 Cr-Original-Commit-Position: refs/heads/master@{#42828} Committed: https://chromium.googlesource.com/v8/v8/+/e8e2e3c826d42490f809e1c45750bbb438b... Review-Url: https://codereview.chromium.org/2668753004 Cr-Commit-Position: refs/heads/master@{#42862} Committed: https://chromium.googlesource.com/v8/v8/+/d8ab932ceb3b906f36ab3216f84d8e626b3... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/d8ab932ceb3b906f36ab3216f84d8e626b3... |
