Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2667993002: Revert of [test] Add back lsan leak detection (Closed)

Created:
3 years, 10 months ago by Michael Achenbach
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [test] Add back lsan leak detection (patchset #4 id:60001 of https://codereview.chromium.org/2592663004/ ) Reason for revert: Breaks mac asan. Need to keep leak check off on mac. Original issue's description: > [test] Add back lsan leak detection > > BUG=chromium:662388 > TBR=yangguo@chromium.org, glider@chromium.org, titzer@chromium.org > > Review-Url: https://codereview.chromium.org/2592663004 > Cr-Commit-Position: refs/heads/master@{#42815} > Committed: https://chromium.googlesource.com/v8/v8/+/e196d00df587b6513eb79059cd96e259dd0a763f TBR=yangguo@chromium.org,glider@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:662388 Review-Url: https://codereview.chromium.org/2667993002 Cr-Commit-Position: refs/heads/master@{#42816} Committed: https://chromium.googlesource.com/v8/v8/+/9cf7cb4c6784372e5820049cf91423c9b58d15e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -42 lines) Patch
M gni/isolate.gni View 2 chunks +0 lines, -7 lines 0 comments Download
M gypfiles/isolate.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D tools/memory/lsan/suppressions.txt View 1 chunk +0 lines, -19 lines 0 comments Download
M tools/run-tests.py View 1 chunk +1 line, -8 lines 0 comments Download
M tools/testrunner/testrunner.isolate View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [test] Add back lsan leak detection
3 years, 10 months ago (2017-01-31 15:12:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667993002/1
3 years, 10 months ago (2017-01-31 15:12:03 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 15:12:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9cf7cb4c6784372e5820049cf91423c9b58...

Powered by Google App Engine
This is Rietveld 408576698