[test] Add back lsan leak detection

[test] Add back lsan leak detection

BUG=chromium:662388
TBR=yangguo@chromium.org, glider@chromium.org, titzer@chromium.org

Review-Url: https://codereview.chromium.org/2592663004
Cr-Commit-Position: refs/heads/master@{#42815}
Committed: https://chromium.googlesource.com/v8/v8/+/e196d00df587b6513eb79059cd96e259dd0a763f

[Michael Achenbach, 2017-01-31 14:25:22]

Description was changed from

==========
[test] Add back lsan leak detection

BUG=chromium:656900
==========

to

==========
[test] Add back lsan leak detection

BUG=chromium:662388
==========

[Michael Achenbach, 2017-01-31 14:25:40]

Description was changed from

==========
[test] Add back lsan leak detection

BUG=chromium:662388
==========

to

==========
[test] Add back lsan leak detection

BUG=chromium:662388
TBR=yangguo@chromium.org, glider@chromium.org, titzer@chromium.org
==========

[Michael Achenbach, 2017-01-31 14:28:10]

machenbach@chromium.org changed reviewers:
+ glider@chromium.org, titzer@chromium.org, yangguo@chromium.org

[Michael Achenbach, 2017-01-31 14:28:11]

PTAL.

This adds back leak detection, which got lost during the gn transition.

Landing this without suppressions seems to be impossible. Once a leak was fixed,
a new one showed up. It's ping/ponging since weeks now.

The plan is to add these suppressions, disallow adding new ones and fix them
afterwards. Like that we avoid new leaks.

Patch 3 shows a run without suppressions (i.e. has all the failures). Patch 4
adds the suppressions.

[Michael Achenbach, 2017-01-31 14:30:21]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 14:30:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Potapenko, 2017-01-31 14:34:12]

rubberstamp LGTM

https://codereview.chromium.org/2592663004/diff/60001/tools/memory/lsan/suppr...
File tools/memory/lsan/suppressions.txt (right):

https://codereview.chromium.org/2592663004/diff/60001/tools/memory/lsan/suppr...
tools/memory/lsan/suppressions.txt:4: # cctest
Are there bugs filed for these suppressions? If so, please add bug IDs here to
ease tracking them.

[Yang, 2017-01-31 14:53:41]

lgtm

[Michael Achenbach, 2017-01-31 14:55:37]

https://codereview.chromium.org/2592663004/diff/60001/tools/memory/lsan/suppr...
File tools/memory/lsan/suppressions.txt (right):

https://codereview.chromium.org/2592663004/diff/60001/tools/memory/lsan/suppr...
tools/memory/lsan/suppressions.txt:4: # cctest
On 2017/01/31 14:34:11, Alexander Potapenko wrote:
> Are there bugs filed for these suppressions? If so, please add bug IDs here to
> ease tracking them.

Nope, there's only the one issue attached to the bug. There should be max 2-3
root causes I think. I'll pass the bug around until they're all fixed.

[commit-bot: I haz the power, 2017-01-31 14:55:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 14:55:40]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2017-01-31 15:04:40]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2017-01-31 15:04:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 15:07:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485875080397020,
"parent_rev": "28dc846ff3787f42fd8c8016d750d244e6cb9444", "commit_rev":
"e196d00df587b6513eb79059cd96e259dd0a763f"}

[commit-bot: I haz the power, 2017-01-31 15:07:03]

Description was changed from

==========
[test] Add back lsan leak detection

BUG=chromium:662388
TBR=yangguo@chromium.org, glider@chromium.org, titzer@chromium.org
==========

to

==========
[test] Add back lsan leak detection

BUG=chromium:662388
TBR=yangguo@chromium.org, glider@chromium.org, titzer@chromium.org

Review-Url: https://codereview.chromium.org/2592663004
Cr-Commit-Position: refs/heads/master@{#42815}
Committed:
https://chromium.googlesource.com/v8/v8/+/e196d00df587b6513eb79059cd96e259dd0...
==========

[commit-bot: I haz the power, 2017-01-31 15:07:04]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/e196d00df587b6513eb79059cd96e259dd0...

[Michael Achenbach, 2017-01-31 15:11:59]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2667993002/ by machenbach@chromium.org.

The reason for reverting is: Breaks mac asan. Need to keep leak check off on
mac..