Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2667963002: [stubs] Remove StringIndexOfChar (Closed)

Created:
3 years, 10 months ago by jgruber
Modified:
3 years, 10 months ago
Reviewers:
Camillo Bruni
CC:
Igor Sheludko, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[csa] Remove StringIndexOfChar The StringIndexOf stub does the same thing but better (it uses memchr instead of a manual loop). Review-Url: https://codereview.chromium.org/2667963002 Cr-Commit-Position: refs/heads/master@{#42923} Committed: https://chromium.googlesource.com/v8/v8/+/bff24112faa64c43f00cb68c0fbd5f6987f248ab

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -87 lines) Patch
M src/builtins/builtins-regexp.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 3 chunks +10 lines, -8 lines 0 comments Download
M src/code-stub-assembler.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/code-stub-assembler.cc View 1 1 chunk +0 lines, -67 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (13 generated)
jgruber
3 years, 10 months ago (2017-02-02 14:34:13 UTC) #11
Camillo Bruni
LGTM, nice! I like code being removed :)
3 years, 10 months ago (2017-02-03 00:09:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667963002/20001
3 years, 10 months ago (2017-02-03 12:18:53 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 12:45:40 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/bff24112faa64c43f00cb68c0fbd5f6987f...

Powered by Google App Engine
This is Rietveld 408576698