Fix HttpCache creation to use the correct API: CreateMainHttpCache and

Fix the code to use the correct API when creating HttpCache:
CreaetMainHttpCache and CreateHttpCache currently
share the same API, though CreaetMainHttpCache should take
HttpNetworkSession which has never been used for HttpCache creation
and CreateHttpCache should take a shared HttpNetworkSession.

When https://codereview.chromium.org/1814543002 landed, the code
should call CreateMainHttpCache than CreateHttpCache as it's no
longer sharing the HttpNetworkSession with the transaction factory
in main_request_context_storage.


BUG=686631
Review-Url: https://codereview.chromium.org/2667633003
Cr-Commit-Position: refs/heads/master@{#447097}
Committed: https://chromium.googlesource.com/chromium/src/+/7bd9ad76d703e4b07c39c305252e14926e3b995e

[Zhongyi Shi, 2017-01-30 19:14:31]

Description was changed from

==========
Fix HttpCache creation to use the correct API: CreateMainHttpCache and
CreateHttpCache. CreaetMainHttpCache and CreateHttpCache currently
share the same API, though CreaetMainHttpCache should take
HttpNetworkSession which has never been used for HttpCache creation
and CreateHttpCache should take a shared HttpNetworkSession.

When https://codereview.chromium.org/1814543002 landed, the code
should now call CreateMainHttpCache from CreateHttpCache as it's no
longer sharing the HttpNetworkSession with the transaction factory
in main_request_context_storage.


BUG=686631
==========

to

==========
Fix HttpCache creation to use the correct API: CreateMainHttpCache and
CreateHttpCache. CreaetMainHttpCache and CreateHttpCache currently
share the same API, though CreaetMainHttpCache should take
HttpNetworkSession which has never been used for HttpCache creation
and CreateHttpCache should take a shared HttpNetworkSession.

When https://codereview.chromium.org/1814543002 landed, the code
should call CreateMainHttpCache from CreateHttpCache as it's no
longer sharing the HttpNetworkSession with the transaction factory
in main_request_context_storage.


BUG=686631
==========

[Zhongyi Shi, 2017-01-30 19:14:31]

zhongyi@chromium.org changed reviewers:
+ mmenke@chromium.org

[Zhongyi Shi, 2017-01-30 19:19:28]

Description was changed from

==========
Fix HttpCache creation to use the correct API: CreateMainHttpCache and
CreateHttpCache. CreaetMainHttpCache and CreateHttpCache currently
share the same API, though CreaetMainHttpCache should take
HttpNetworkSession which has never been used for HttpCache creation
and CreateHttpCache should take a shared HttpNetworkSession.

When https://codereview.chromium.org/1814543002 landed, the code
should call CreateMainHttpCache from CreateHttpCache as it's no
longer sharing the HttpNetworkSession with the transaction factory
in main_request_context_storage.


BUG=686631
==========

to

==========
Fix the code to use the correct API when creating HttpCache: CreaetMainHttpCache
and CreateHttpCache currently
share the same API, though CreaetMainHttpCache should take
HttpNetworkSession which has never been used for HttpCache creation
and CreateHttpCache should take a shared HttpNetworkSession.

When https://codereview.chromium.org/1814543002 landed, the code
should call CreateMainHttpCache from CreateHttpCache as it's no
longer sharing the HttpNetworkSession with the transaction factory
in main_request_context_storage.


BUG=686631
==========

[Zhongyi Shi, 2017-01-30 19:19:41]

Description was changed from

==========
Fix the code to use the correct API when creating HttpCache: CreaetMainHttpCache
and CreateHttpCache currently
share the same API, though CreaetMainHttpCache should take
HttpNetworkSession which has never been used for HttpCache creation
and CreateHttpCache should take a shared HttpNetworkSession.

When https://codereview.chromium.org/1814543002 landed, the code
should call CreateMainHttpCache from CreateHttpCache as it's no
longer sharing the HttpNetworkSession with the transaction factory
in main_request_context_storage.


BUG=686631
==========

to

==========
Fix the code to use the correct API when creating HttpCache:
CreaetMainHttpCache and CreateHttpCache currently
share the same API, though CreaetMainHttpCache should take
HttpNetworkSession which has never been used for HttpCache creation
and CreateHttpCache should take a shared HttpNetworkSession.

When https://codereview.chromium.org/1814543002 landed, the code
should call CreateMainHttpCache from CreateHttpCache as it's no
longer sharing the HttpNetworkSession with the transaction factory
in main_request_context_storage.


BUG=686631
==========

[Zhongyi Shi, 2017-01-30 19:20:14]

Description was changed from

==========
Fix the code to use the correct API when creating HttpCache:
CreaetMainHttpCache and CreateHttpCache currently
share the same API, though CreaetMainHttpCache should take
HttpNetworkSession which has never been used for HttpCache creation
and CreateHttpCache should take a shared HttpNetworkSession.

When https://codereview.chromium.org/1814543002 landed, the code
should call CreateMainHttpCache from CreateHttpCache as it's no
longer sharing the HttpNetworkSession with the transaction factory
in main_request_context_storage.


BUG=686631
==========

to

==========
Fix the code to use the correct API when creating HttpCache:
CreaetMainHttpCache and CreateHttpCache currently
share the same API, though CreaetMainHttpCache should take
HttpNetworkSession which has never been used for HttpCache creation
and CreateHttpCache should take a shared HttpNetworkSession.

When https://codereview.chromium.org/1814543002 landed, the code
should call CreateMainHttpCache than CreateHttpCache as it's no
longer sharing the HttpNetworkSession with the transaction factory
in main_request_context_storage.


BUG=686631
==========

[Zhongyi Shi, 2017-01-30 19:21:42]

Matt, 

this CL fixes we're using the correct API to create the HttpCache after recent
changes so that we could move forward to change the API for CreateHttpFactory.
PTAL, thanks!

[mmenke, 2017-01-30 21:33:57]

On 2017/01/30 19:21:42, Zhongyi Shi wrote:
> Matt, 
> 
> this CL fixes we're using the correct API to create the HttpCache after recent
> changes so that we could move forward to change the API for CreateHttpFactory.
> PTAL, thanks!

LGTM!

[Zhongyi Shi, 2017-01-30 21:39:10]

The CQ bit was checked by zhongyi@chromium.org

[commit-bot: I haz the power, 2017-01-30 21:40:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 22:53:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485812350814300, "parent_rev":
"6824489b20be7b73b242bb1f6e6827f6dc3e9454", "commit_rev":
"7bd9ad76d703e4b07c39c305252e14926e3b995e"}

[commit-bot: I haz the power, 2017-01-30 22:53:50]

Description was changed from

==========
Fix the code to use the correct API when creating HttpCache:
CreaetMainHttpCache and CreateHttpCache currently
share the same API, though CreaetMainHttpCache should take
HttpNetworkSession which has never been used for HttpCache creation
and CreateHttpCache should take a shared HttpNetworkSession.

When https://codereview.chromium.org/1814543002 landed, the code
should call CreateMainHttpCache than CreateHttpCache as it's no
longer sharing the HttpNetworkSession with the transaction factory
in main_request_context_storage.


BUG=686631
==========

to

==========
Fix the code to use the correct API when creating HttpCache:
CreaetMainHttpCache and CreateHttpCache currently
share the same API, though CreaetMainHttpCache should take
HttpNetworkSession which has never been used for HttpCache creation
and CreateHttpCache should take a shared HttpNetworkSession.

When https://codereview.chromium.org/1814543002 landed, the code
should call CreateMainHttpCache than CreateHttpCache as it's no
longer sharing the HttpNetworkSession with the transaction factory
in main_request_context_storage.


BUG=686631

Review-Url: https://codereview.chromium.org/2667633003
Cr-Commit-Position: refs/heads/master@{#447097}
Committed:
https://chromium.googlesource.com/chromium/src/+/7bd9ad76d703e4b07c39c305252e...
==========

[commit-bot: I haz the power, 2017-01-30 22:53:52]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7bd9ad76d703e4b07c39c305252e...