Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2660983002: Change ProfileIOData::CreateHttpFactory to take an (Closed)

Created:
3 years, 10 months ago by Zhongyi Shi
Modified:
3 years, 10 months ago
Reviewers:
jimenezjr07.MJ, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ProfileIOData::CreateHttpFactory to take an HttpTransactionFactory to differentiate from ProfileIOData:::CreateMainHttpFactory. The HttpTransactionFactory created will be enforced to share the HttpNetowrkSession with the factory passed in. BUG=686631 Review-Url: https://codereview.chromium.org/2660983002 Cr-Commit-Position: refs/heads/master@{#447306} Committed: https://chromium.googlesource.com/chromium/src/+/1795d4374bb73cf4bf9641a1df1a2f30936f0d5b

Patch Set 1 #

Patch Set 2 : rebase after upstream landed #

Total comments: 2

Patch Set 3 : Get HttpTransactionFactory from URLRequestContext directly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M chrome/browser/profiles/profile_impl_io_data.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
Zhongyi Shi
3 years, 10 months ago (2017-01-30 23:44:31 UTC) #3
mmenke
https://codereview.chromium.org/2660983002/diff/20001/net/url_request/url_request_context_storage.h File net/url_request/url_request_context_storage.h (right): https://codereview.chromium.org/2660983002/diff/20001/net/url_request/url_request_context_storage.h#newcode90 net/url_request/url_request_context_storage.h:90: } Not needed - can just get this from ...
3 years, 10 months ago (2017-01-31 15:17:59 UTC) #7
Zhongyi Shi
Matt, PTAL! https://codereview.chromium.org/2660983002/diff/20001/net/url_request/url_request_context_storage.h File net/url_request/url_request_context_storage.h (right): https://codereview.chromium.org/2660983002/diff/20001/net/url_request/url_request_context_storage.h#newcode90 net/url_request/url_request_context_storage.h:90: } On 2017/01/31 15:17:59, mmenke (Out Feb ...
3 years, 10 months ago (2017-01-31 18:38:21 UTC) #10
mmenke
LGTM
3 years, 10 months ago (2017-01-31 18:39:20 UTC) #11
jimenezjr07.MJ
lgtm Nenaymiguel
3 years, 10 months ago (2017-01-31 19:25:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660983002/40001
3 years, 10 months ago (2017-01-31 19:44:05 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 19:55:26 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1795d4374bb73cf4bf9641a1df1a...

Powered by Google App Engine
This is Rietveld 408576698