Change ProfileIOData::CreateHttpFactory to take an

Change ProfileIOData::CreateHttpFactory to take an
HttpTransactionFactory to differentiate from
ProfileIOData:::CreateMainHttpFactory. The HttpTransactionFactory
created will be enforced to share the HttpNetowrkSession with the
factory passed in.

BUG=686631
Review-Url: https://codereview.chromium.org/2660983002
Cr-Commit-Position: refs/heads/master@{#447306}
Committed: https://chromium.googlesource.com/chromium/src/+/1795d4374bb73cf4bf9641a1df1a2f30936f0d5b

[Zhongyi Shi, 2017-01-30 23:44:03]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[Zhongyi Shi, 2017-01-30 23:44:30]

zhongyi@chromium.org changed reviewers:
+ mmenke@chromium.org

[commit-bot: I haz the power, 2017-01-30 23:45:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 01:00:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 01:00:44]

Dry run: This issue passed the CQ dry run.

[mmenke, 2017-01-31 15:17:59]

https://codereview.chromium.org/2660983002/diff/20001/net/url_request/url_req...
File net/url_request/url_request_context_storage.h (right):

https://codereview.chromium.org/2660983002/diff/20001/net/url_request/url_req...
net/url_request/url_request_context_storage.h:90: }
Not needed - can just get this from the URLRequestContext directly.

[Zhongyi Shi, 2017-01-31 18:21:09]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 18:21:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhongyi Shi, 2017-01-31 18:38:21]

Matt, PTAL!

https://codereview.chromium.org/2660983002/diff/20001/net/url_request/url_req...
File net/url_request/url_request_context_storage.h (right):

https://codereview.chromium.org/2660983002/diff/20001/net/url_request/url_req...
net/url_request/url_request_context_storage.h:90: }
On 2017/01/31 15:17:59, mmenke (Out Feb 4 to March 5) wrote:
> Not needed - can just get this from the URLRequestContext directly.

Done.

[mmenke, 2017-01-31 18:39:20]

LGTM

[commit-bot: I haz the power, 2017-01-31 19:19:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 19:19:50]

Dry run: This issue passed the CQ dry run.

[jimenezjr07.MJ, 2017-01-31 19:25:41]

jimenezjr07.mj@gmail.com changed reviewers:
+ jimenezjr07.MJ@gmail.com

[jimenezjr07.MJ, 2017-01-31 19:25:42]

lgtm

Nenaymiguel

[Zhongyi Shi, 2017-01-31 19:43:18]

The CQ bit was checked by zhongyi@chromium.org

[commit-bot: I haz the power, 2017-01-31 19:44:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 19:54:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485891798130160,
"parent_rev": "a863007a23891c489f6f58e4cce1bd93cd87fb5d", "commit_rev":
"1795d4374bb73cf4bf9641a1df1a2f30936f0d5b"}

[commit-bot: I haz the power, 2017-01-31 19:55:25]

Description was changed from

==========
Change ProfileIOData::CreateHttpFactory to take an
HttpTransactionFactory to differentiate from
ProfileIOData:::CreateMainHttpFactory. The HttpTransactionFactory
created will be enforced to share the HttpNetowrkSession with the
factory passed in.

BUG=686631
==========

to

==========
Change ProfileIOData::CreateHttpFactory to take an
HttpTransactionFactory to differentiate from
ProfileIOData:::CreateMainHttpFactory. The HttpTransactionFactory
created will be enforced to share the HttpNetowrkSession with the
factory passed in.

BUG=686631

Review-Url: https://codereview.chromium.org/2660983002
Cr-Commit-Position: refs/heads/master@{#447306}
Committed:
https://chromium.googlesource.com/chromium/src/+/1795d4374bb73cf4bf9641a1df1a...
==========

[commit-bot: I haz the power, 2017-01-31 19:55:26]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1795d4374bb73cf4bf9641a1df1a...