Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2667553003: Revert of ValueSerializer: Distinguish between 'undefined' and an absent property. (Closed)

Created:
3 years, 10 months ago by Michael Achenbach
Modified:
3 years, 10 months ago
Reviewers:
jbroman, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of ValueSerializer: Distinguish between 'undefined' and an absent property. (patchset #2 id:20001 of https://codereview.chromium.org/2660093002/ ) Reason for revert: Seems to break layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/13146 https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > ValueSerializer: Distinguish between 'undefined' and an absent property. > > Dealing with this case requires a wire format change. It is possible that an > element can be absent even in an array where the dense format was chosen > (because the array initially had no holes), if the elements are modified while > they are being serialized. In this case, a new tag for the "hole" is emitted. > > The logic to treat undefined in dense arrays as an absent property is restricted > to versions of the wire format that this tag did not exist. > > BUG=chromium:686159, chromium:665820 > > Review-Url: https://codereview.chromium.org/2660093002 > Cr-Commit-Position: refs/heads/master@{#42784} > Committed: https://chromium.googlesource.com/v8/v8/+/dc85f4c8338c1c824af4f7ee3274dc9f95d14e49 TBR=jkummerow@chromium.org,jbroman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:686159, chromium:665820 Review-Url: https://codereview.chromium.org/2667553003 Cr-Commit-Position: refs/heads/master@{#42788} Committed: https://chromium.googlesource.com/v8/v8/+/b861a8400991976e6fd7d7abc9843e4fe7dc576e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -52 lines) Patch
M src/value-serializer.cc View 5 chunks +7 lines, -22 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of ValueSerializer: Distinguish between 'undefined' and an absent property.
3 years, 10 months ago (2017-01-30 19:35:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667553003/1
3 years, 10 months ago (2017-01-30 19:35:19 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 19:35:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b861a8400991976e6fd7d7abc9843e4fe7d...

Powered by Google App Engine
This is Rietveld 408576698