Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 2660093002: ValueSerializer: Distinguish between 'undefined' and an absent property. (Closed)

Created:
3 years, 10 months ago by jbroman
Modified:
3 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ValueSerializer: Distinguish between 'undefined' and an absent property. Dealing with this case requires a wire format change. It is possible that an element can be absent even in an array where the dense format was chosen (because the array initially had no holes), if the elements are modified while they are being serialized. In this case, a new tag for the "hole" is emitted. The logic to treat undefined in dense arrays as an absent property is restricted to versions of the wire format that this tag did not exist. BUG=chromium:686159, chromium:665820 Review-Url: https://codereview.chromium.org/2660093002 Cr-Original-Commit-Position: refs/heads/master@{#42784} Committed: https://chromium.googlesource.com/v8/v8/+/dc85f4c8338c1c824af4f7ee3274dc9f95d14e49 Review-Url: https://codereview.chromium.org/2660093002 Cr-Commit-Position: refs/heads/master@{#42800} Committed: https://chromium.googlesource.com/v8/v8/+/6f1639ed16a21b2395b98e8c61de268a275ee920

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -7 lines) Patch
M src/value-serializer.cc View 1 5 chunks +22 lines, -7 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
jbroman
This also makes the external/wpt/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/structured-clone-message.html layout test pass; I'll send a CL to enable it ...
3 years, 10 months ago (2017-01-28 23:56:39 UTC) #5
Jakob Kummerow
LGTM with a nit https://codereview.chromium.org/2660093002/diff/1/src/value-serializer.cc File src/value-serializer.cc (right): https://codereview.chromium.org/2660093002/diff/1/src/value-serializer.cc#newcode544 src/value-serializer.cc:544: // TODO(jbroman): Distinguish between undefined ...
3 years, 10 months ago (2017-01-30 03:11:38 UTC) #6
jbroman
https://codereview.chromium.org/2660093002/diff/1/src/value-serializer.cc File src/value-serializer.cc (right): https://codereview.chromium.org/2660093002/diff/1/src/value-serializer.cc#newcode544 src/value-serializer.cc:544: // TODO(jbroman): Distinguish between undefined and a hole (this ...
3 years, 10 months ago (2017-01-30 18:08:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660093002/20001
3 years, 10 months ago (2017-01-30 18:08:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/dc85f4c8338c1c824af4f7ee3274dc9f95d14e49
3 years, 10 months ago (2017-01-30 18:43:45 UTC) #13
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2667553003/ by machenbach@chromium.org. ...
3 years, 10 months ago (2017-01-30 19:35:11 UTC) #14
jbroman
Fixed Blink-side test, v8_linux_blink_rel passes. Re-CQing.
3 years, 10 months ago (2017-01-31 01:52:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660093002/20001
3 years, 10 months ago (2017-01-31 01:52:48 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 01:54:32 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/6f1639ed16a21b2395b98e8c61de268a275...

Powered by Google App Engine
This is Rietveld 408576698