Don't invoke goma for linking on mac

Don't invoke goma for linking on mac

Currently, linking with goma causes goma 'local fallback', and goma
allows at most 1 link in parallel (without special flag).

In 520f95147c821e13003362194a5de003a9f5c8f9, linking with goma is
enabled (maybe accidentally). It's better not to use goma for
linking now.

Review-Url: https://codereview.chromium.org/2667383002
Cr-Commit-Position: refs/heads/master@{#447858}
Committed: https://chromium.googlesource.com/chromium/src/+/c398506e3abc0799330e39144194d70c00e4032e

[shinyak (Google), 2017-02-02 04:45:10]

The CQ bit was checked by shinyak@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 04:45:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shinyak, 2017-02-02 04:48:21]

The CQ bit was checked by shinyak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 04:48:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shinyak, 2017-02-02 04:50:21]

shinyak@chromium.org changed reviewers:
+ kmarshall@chromium.org, sdefresne@chromium.org, thakis@chromium.org,
wez@chromium.org
- shinyak@google.com

[shinyak, 2017-02-02 04:50:22]

Hi, I found "ld = cxx" is introduced in this patch. 

https://codereview.chromium.org/2617283002/patch/240001/250005

I'd like to revert this part. Could you review?

[shinyak, 2017-02-02 04:51:44]

Description was changed from

==========
Don't invoke goma for linking on mac

Currently, linking with goma causes goma 'local fallback', and goma
allows at most 1 link in parallel (without special flag).

In 520f95147c821e13003362194a5de003a9f5c8f9, linking with goma is
enabled (maybe accidently). It's better not to use goma for linking
now.
==========

to

==========
Don't invoke goma for linking on mac

Currently, linking with goma causes goma 'local fallback', and goma
allows at most 1 link in parallel (without special flag).

In 520f95147c821e13003362194a5de003a9f5c8f9, linking with goma is
enabled (maybe accidentally). It's better not to use goma for
linking now.
==========

[commit-bot: I haz the power, 2017-02-02 06:57:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 06:57:28]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-02-02 11:51:14]

lgtm

https://codereview.chromium.org/2667383002/diff/20001/build/toolchain/mac/BUI...
File build/toolchain/mac/BUILD.gn (right):

https://codereview.chromium.org/2667383002/diff/20001/build/toolchain/mac/BUI...
build/toolchain/mac/BUILD.gn:146: ld = cxx
I think you can remove this line. The default above should also work for the
linker AFAICT.

[Nico, 2017-02-02 22:11:44]

lgtm if kmarshall likes it. Sorry about missing that in the other review!

[Kevin M, 2017-02-02 22:14:13]

lgtm here too. Didn't know about that goma linter limitation. :\

[Kevin M, 2017-02-02 22:14:19]

The CQ bit was checked by kmarshall@chromium.org

[commit-bot: I haz the power, 2017-02-02 22:14:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 22:21:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486073659971330,
"parent_rev": "d8033dadec98c7c2f4c407f89c128b166b5922ef", "commit_rev":
"c398506e3abc0799330e39144194d70c00e4032e"}

[commit-bot: I haz the power, 2017-02-02 22:22:39]

Description was changed from

==========
Don't invoke goma for linking on mac

Currently, linking with goma causes goma 'local fallback', and goma
allows at most 1 link in parallel (without special flag).

In 520f95147c821e13003362194a5de003a9f5c8f9, linking with goma is
enabled (maybe accidentally). It's better not to use goma for
linking now.
==========

to

==========
Don't invoke goma for linking on mac

Currently, linking with goma causes goma 'local fallback', and goma
allows at most 1 link in parallel (without special flag).

In 520f95147c821e13003362194a5de003a9f5c8f9, linking with goma is
enabled (maybe accidentally). It's better not to use goma for
linking now.

Review-Url: https://codereview.chromium.org/2667383002
Cr-Commit-Position: refs/heads/master@{#447858}
Committed:
https://chromium.googlesource.com/chromium/src/+/c398506e3abc0799330e39144194...
==========

[commit-bot: I haz the power, 2017-02-02 22:22:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c398506e3abc0799330e39144194...