Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: build/toolchain/mac/BUILD.gn

Issue 2667383002: Don't invoke goma for linking on mac (Closed)
Patch Set: fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/mac/BUILD.gn
diff --git a/build/toolchain/mac/BUILD.gn b/build/toolchain/mac/BUILD.gn
index de63e5d5219e374988767010e125a848505ecf98..b417e76a3b0b9d985f1442503b7b9fd93d6f2e0f 100644
--- a/build/toolchain/mac/BUILD.gn
+++ b/build/toolchain/mac/BUILD.gn
@@ -123,6 +123,7 @@ template("mac_toolchain") {
cc = compiler_prefix + _cc
cxx = compiler_prefix + _cxx
+ ld = _cxx
if (use_clang_static_analyzer) {
# Static analysis isn't supported under GOMA. See crbug.com/687245
@@ -141,9 +142,9 @@ template("mac_toolchain") {
cxx = analyzer_wrapper + " --clang-cxx-path=${cxx} --analyzer=" +
rebase_path("//third_party/scan-build/src/libexec/c++-analyzer",
root_build_dir)
- }
- ld = cxx
+ ld = cxx
sdefresne 2017/02/02 11:51:14 I think you can remove this line. The default abov
+ }
linker_driver =
"TOOL_VERSION=${tool_versions.linker_driver} " +
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698