Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2667373003: Change Enterprise.Policies histogram bucket descriptions to policy names (Closed)

Created:
3 years, 10 months ago by pmarko
Modified:
3 years, 10 months ago
CC:
chromium-reviews, tnagel+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change Enterprise.Policies histogram bucket descriptions to policy names Adapt the python script generating Enterprise.Policies in histograms.xml to use policy names instead of captions for bucket descriptions. Also, mention the script in policy_templates.json and the PRESUBMIT script for cross-checking if every policy has a bucket in histograms.xml. BUG=618964 Review-Url: https://codereview.chromium.org/2667373003 Cr-Commit-Position: refs/heads/master@{#450316} Committed: https://chromium.googlesource.com/chromium/src/+/afdfa8058e3d9e8fcfab6fd09ebf68d9ec31d3c7

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+370 lines, -498 lines) Patch
M components/policy/resources/PRESUBMIT.py View 1 chunk +3 lines, -1 line 0 comments Download
M components/policy/resources/policy_templates.json View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +365 lines, -477 lines 0 comments Download
M tools/metrics/histograms/update_policies.py View 2 chunks +1 line, -19 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pmarko
haraken@chromium.org: Please review changes in tools/metrics/histograms/histograms.xml isherman@chromium.org: Please review changes in tools/metrics/histograms/update_policies.py tnagel@chromium.org: Please review ...
3 years, 10 months ago (2017-02-02 13:08:19 UTC) #2
haraken
+isherman for histograms.xml
3 years, 10 months ago (2017-02-02 15:19:35 UTC) #3
Ilya Sherman
LGTM
3 years, 10 months ago (2017-02-02 20:38:46 UTC) #4
Thiemo Nagel
LGTM
3 years, 10 months ago (2017-02-03 12:53:37 UTC) #5
Thiemo Nagel
https://memegen.googleplex.com/6346339817881600
3 years, 10 months ago (2017-02-03 12:57:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667373003/20001
3 years, 10 months ago (2017-02-14 09:33:08 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 10:35:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/afdfa8058e3d9e8fcfab6fd09ebf...

Powered by Google App Engine
This is Rietveld 408576698