components/policy/resources/PRESUBMIT.py - Issue 2667373003: Change Enterprise.Policies histogram bucket descriptions to policy names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/resources/PRESUBMIT.py

Issue 2667373003: Change Enterprise.Policies histogram bucket descriptions to policy names (Closed)

Patch Set: Rebase. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/resources/PRESUBMIT.py

diff --git a/components/policy/resources/PRESUBMIT.py b/components/policy/resources/PRESUBMIT.py

index b59e8d3504f25bd5b355e988053a69bee0ebc045..b3264a1c680101f1a8844d25c1edb7789bb1523e 100644

--- a/components/policy/resources/PRESUBMIT.py

+++ b/components/policy/resources/PRESUBMIT.py

@@ -90,7 +90,9 @@ def _CheckPolicyHistograms(input_api, output_api, policies):

error_missing = ('Policy \'%s\' was added to policy_templates.json but not '

'to src/tools/metrics/histograms/histograms.xml. '

- 'Please update both files.')

+ 'Please update both files. To regenerate the policy part '

+ 'of histograms.xml, run:\n'

+ 'python tools/metrics/histograms/update_policies.py')

results = []

for policy in policies:

if policy['id'] not in policy_ids:

« no previous file with comments | « no previous file | components/policy/resources/policy_templates.json » ('j') | no next file with comments »