Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2667343006: Componentize safe_browsing [X+1] : move the renderer part to component.

Created:
3 years, 10 months ago by timvolodine
Modified:
3 years, 9 months ago
Reviewers:
Jialiu Lin
CC:
chromium-reviews, grt+watch_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, Tobias Sargeant, Nathan Parker, vakh (use Gerrit instead)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize safe_browsing [X+1] : move the renderer part to component. WIP: do not submit yet This patch moves the chrome/renderer/safe_browsing/ code to component. As a side-effect this enables support for threat reporting functionality for embedders like Android WebView. NOTE: work in progress, depends on patch for moving protos BUG=488675

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -3943 lines) Patch
M chrome/renderer/BUILD.gn View 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/renderer/safe_browsing/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/renderer/safe_browsing/feature_extractor_clock.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/renderer/safe_browsing/feature_extractor_clock.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/renderer/safe_browsing/features.h View 1 chunk +0 lines, -181 lines 0 comments Download
D chrome/renderer/safe_browsing/features.cc View 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/renderer/safe_browsing/features_unittest.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/renderer/safe_browsing/mock_feature_extractor_clock.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/renderer/safe_browsing/mock_feature_extractor_clock.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/renderer/safe_browsing/murmurhash3_util.h View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/renderer/safe_browsing/murmurhash3_util.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/renderer/safe_browsing/murmurhash3_util_unittest.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/renderer/safe_browsing/phishing_classifier.h View 1 chunk +0 lines, -155 lines 0 comments Download
D chrome/renderer/safe_browsing/phishing_classifier.cc View 1 chunk +0 lines, -251 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
D chrome/renderer/safe_browsing/phishing_classifier_delegate.h View 1 chunk +0 lines, -145 lines 0 comments Download
D chrome/renderer/safe_browsing/phishing_classifier_delegate.cc View 1 chunk +0 lines, -296 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
D chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h View 1 chunk +0 lines, -154 lines 0 comments Download
D chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc View 1 chunk +0 lines, -502 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
D chrome/renderer/safe_browsing/phishing_term_feature_extractor.h View 1 chunk +0 lines, -172 lines 0 comments Download
D chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc View 1 chunk +0 lines, -298 lines 0 comments Download
D chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc View 1 chunk +0 lines, -469 lines 0 comments Download
D chrome/renderer/safe_browsing/phishing_url_feature_extractor.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/renderer/safe_browsing/phishing_url_feature_extractor_unittest.cc View 1 chunk +0 lines, -129 lines 0 comments Download
D chrome/renderer/safe_browsing/scorer.h View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/renderer/safe_browsing/scorer.cc View 1 chunk +0 lines, -132 lines 0 comments Download
D chrome/renderer/safe_browsing/scorer_unittest.cc View 1 chunk +0 lines, -149 lines 0 comments Download
D chrome/renderer/safe_browsing/test_utils.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/renderer/safe_browsing/test_utils.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/renderer/safe_browsing/threat_dom_details.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/renderer/safe_browsing/threat_dom_details.cc View 1 chunk +0 lines, -144 lines 0 comments Download
M chrome/renderer/safe_browsing/threat_dom_details_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M components/safe_browsing/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/safe_browsing/renderer/BUILD.gn View 1 chunk +75 lines, -0 lines 0 comments Download
A components/safe_browsing/renderer/DEPS View 1 chunk +9 lines, -0 lines 0 comments Download
A components/safe_browsing/renderer/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A + components/safe_browsing/renderer/feature_extractor_clock.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/safe_browsing/renderer/feature_extractor_clock.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/safe_browsing/renderer/features.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/safe_browsing/renderer/features.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/safe_browsing/renderer/features_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/safe_browsing/renderer/mock_feature_extractor_clock.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/safe_browsing/renderer/mock_feature_extractor_clock.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/safe_browsing/renderer/murmurhash3_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/safe_browsing/renderer/murmurhash3_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/safe_browsing/renderer/murmurhash3_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/safe_browsing/renderer/phishing_classifier.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/safe_browsing/renderer/phishing_classifier.cc View 2 chunks +8 lines, -8 lines 0 comments Download
A + components/safe_browsing/renderer/phishing_classifier_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/safe_browsing/renderer/phishing_classifier_delegate.cc View 2 chunks +5 lines, -4 lines 0 comments Download
A + components/safe_browsing/renderer/phishing_dom_feature_extractor.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/safe_browsing/renderer/phishing_dom_feature_extractor.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/safe_browsing/renderer/phishing_term_feature_extractor.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/safe_browsing/renderer/phishing_term_feature_extractor.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/safe_browsing/renderer/phishing_term_feature_extractor_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/safe_browsing/renderer/phishing_url_feature_extractor.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/safe_browsing/renderer/phishing_url_feature_extractor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/safe_browsing/renderer/phishing_url_feature_extractor_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/safe_browsing/renderer/scorer.h View 3 chunks +4 lines, -3 lines 0 comments Download
A + components/safe_browsing/renderer/scorer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A + components/safe_browsing/renderer/scorer_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A + components/safe_browsing/renderer/test_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/safe_browsing/renderer/test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/safe_browsing/renderer/threat_dom_details.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/safe_browsing/renderer/threat_dom_details.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
timvolodine
FYI for now, currently work in progress, but coming soon... +owners: nparker@,vakh@ +cc:sgurun@,tobiasjs@
3 years, 10 months ago (2017-02-03 02:50:47 UTC) #2
sgurun-gerrit only
On 2017/02/03 02:50:47, timvolodine wrote: > FYI for now, currently work in progress, but coming ...
3 years, 10 months ago (2017-02-03 03:15:42 UTC) #3
vakh (use Gerrit instead)
On 2017/02/03 03:15:42, sgurun wrote: > On 2017/02/03 02:50:47, timvolodine wrote: > > FYI for ...
3 years, 10 months ago (2017-02-14 00:14:08 UTC) #4
vakh (use Gerrit instead)
3 years, 10 months ago (2017-02-14 00:14:23 UTC) #6
timvolodine
3 years, 9 months ago (2017-03-10 13:21:04 UTC) #7
On 2017/02/03 03:15:42, sgurun wrote:
> On 2017/02/03 02:50:47, timvolodine wrote:
> > FYI for now, currently work in progress, but coming soon...
> > 
> > +owners: nparker@,vakh@
> > +cc:sgurun@,tobiasjs@
> 
> Tim are you sure this is needed for webview reporting? 
> 
> We do not want to have client side reporting in Android webview (and not in
> chrome on android too).
> 
> Let's have a design document first to discuss.

As discussed offline this would be needed for the reporting functionality in
WebView. This patch depends on moving of protos:
https://codereview.chromium.org/2743563006/, will rebase and follow-up here and
once it lands.

Powered by Google App Engine
This is Rietveld 408576698