Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Side by Side Diff: chrome/renderer/safe_browsing/features.cc

Issue 2667343006: Componentize safe_browsing [X+1] : move the renderer part to component.
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/renderer/safe_browsing/features.h"
6
7 #include "base/logging.h"
8 #include "base/metrics/histogram_macros.h"
9
10 namespace safe_browsing {
11
12 const size_t FeatureMap::kMaxFeatureMapSize = 10000;
13
14 FeatureMap::FeatureMap() {}
15 FeatureMap::~FeatureMap() {}
16
17 bool FeatureMap::AddBooleanFeature(const std::string& name) {
18 return AddRealFeature(name, 1.0);
19 }
20
21 bool FeatureMap::AddRealFeature(const std::string& name, double value) {
22 if (features_.size() >= kMaxFeatureMapSize) {
23 // If we hit this case, it indicates that either kMaxFeatureMapSize is
24 // too small, or there is a bug causing too many features to be added.
25 // In this case, we'll log to a histogram so we can see that this is
26 // happening, and make phishing classification fail silently.
27 LOG(ERROR) << "Not adding feature: " << name << " because the "
28 << "feature map is too large.";
29 UMA_HISTOGRAM_COUNTS("SBClientPhishing.TooManyFeatures", 1);
30 return false;
31 }
32 // We only expect features in the range [0.0, 1.0], so fail if the feature is
33 // outside this range.
34 if (value < 0.0 || value > 1.0) {
35 LOG(ERROR) << "Not adding feature: " << name << " because the value "
36 << value << " is not in the range [0.0, 1.0].";
37 UMA_HISTOGRAM_COUNTS("SBClientPhishing.IllegalFeatureValue", 1);
38 return false;
39 }
40
41 features_[name] = value;
42 return true;
43 }
44
45 void FeatureMap::Clear() {
46 features_.clear();
47 }
48
49 namespace features {
50 // URL host features
51 const char kUrlHostIsIpAddress[] = "UrlHostIsIpAddress";
52 const char kUrlTldToken[] = "UrlTld=";
53 const char kUrlDomainToken[] = "UrlDomain=";
54 const char kUrlOtherHostToken[] = "UrlOtherHostToken=";
55
56 // URL host aggregate features
57 const char kUrlNumOtherHostTokensGTOne[] = "UrlNumOtherHostTokens>1";
58 const char kUrlNumOtherHostTokensGTThree[] = "UrlNumOtherHostTokens>3";
59
60 // URL path features
61 const char kUrlPathToken[] = "UrlPathToken=";
62
63 // DOM HTML form features
64 const char kPageHasForms[] = "PageHasForms";
65 const char kPageActionOtherDomainFreq[] = "PageActionOtherDomainFreq";
66 const char kPageActionURL[] = "PageActionURL=";
67 const char kPageHasTextInputs[] = "PageHasTextInputs";
68 const char kPageHasPswdInputs[] = "PageHasPswdInputs";
69 const char kPageHasRadioInputs[] = "PageHasRadioInputs";
70 const char kPageHasCheckInputs[] = "PageHasCheckInputs";
71
72 // DOM HTML link features
73 const char kPageExternalLinksFreq[] = "PageExternalLinksFreq";
74 const char kPageLinkDomain[] = "PageLinkDomain=";
75 const char kPageSecureLinksFreq[] = "PageSecureLinksFreq";
76
77 // DOM HTML script features
78 const char kPageNumScriptTagsGTOne[] = "PageNumScriptTags>1";
79 const char kPageNumScriptTagsGTSix[] = "PageNumScriptTags>6";
80
81 // Other DOM HTML features
82 const char kPageImgOtherDomainFreq[] = "PageImgOtherDomainFreq";
83
84 // Page term features
85 const char kPageTerm[] = "PageTerm=";
86
87 } // namespace features
88 } // namespace safe_browsing
OLDNEW
« no previous file with comments | « chrome/renderer/safe_browsing/features.h ('k') | chrome/renderer/safe_browsing/features_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698