Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4904)

Unified Diff: chrome/renderer/safe_browsing/features.cc

Issue 2667343006: Componentize safe_browsing [X+1] : move the renderer part to component.
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/safe_browsing/features.h ('k') | chrome/renderer/safe_browsing/features_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/safe_browsing/features.cc
diff --git a/chrome/renderer/safe_browsing/features.cc b/chrome/renderer/safe_browsing/features.cc
deleted file mode 100644
index 3bf7470858121171a1e9839d6e33a3f265ad3f38..0000000000000000000000000000000000000000
--- a/chrome/renderer/safe_browsing/features.cc
+++ /dev/null
@@ -1,88 +0,0 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/renderer/safe_browsing/features.h"
-
-#include "base/logging.h"
-#include "base/metrics/histogram_macros.h"
-
-namespace safe_browsing {
-
-const size_t FeatureMap::kMaxFeatureMapSize = 10000;
-
-FeatureMap::FeatureMap() {}
-FeatureMap::~FeatureMap() {}
-
-bool FeatureMap::AddBooleanFeature(const std::string& name) {
- return AddRealFeature(name, 1.0);
-}
-
-bool FeatureMap::AddRealFeature(const std::string& name, double value) {
- if (features_.size() >= kMaxFeatureMapSize) {
- // If we hit this case, it indicates that either kMaxFeatureMapSize is
- // too small, or there is a bug causing too many features to be added.
- // In this case, we'll log to a histogram so we can see that this is
- // happening, and make phishing classification fail silently.
- LOG(ERROR) << "Not adding feature: " << name << " because the "
- << "feature map is too large.";
- UMA_HISTOGRAM_COUNTS("SBClientPhishing.TooManyFeatures", 1);
- return false;
- }
- // We only expect features in the range [0.0, 1.0], so fail if the feature is
- // outside this range.
- if (value < 0.0 || value > 1.0) {
- LOG(ERROR) << "Not adding feature: " << name << " because the value "
- << value << " is not in the range [0.0, 1.0].";
- UMA_HISTOGRAM_COUNTS("SBClientPhishing.IllegalFeatureValue", 1);
- return false;
- }
-
- features_[name] = value;
- return true;
-}
-
-void FeatureMap::Clear() {
- features_.clear();
-}
-
-namespace features {
-// URL host features
-const char kUrlHostIsIpAddress[] = "UrlHostIsIpAddress";
-const char kUrlTldToken[] = "UrlTld=";
-const char kUrlDomainToken[] = "UrlDomain=";
-const char kUrlOtherHostToken[] = "UrlOtherHostToken=";
-
-// URL host aggregate features
-const char kUrlNumOtherHostTokensGTOne[] = "UrlNumOtherHostTokens>1";
-const char kUrlNumOtherHostTokensGTThree[] = "UrlNumOtherHostTokens>3";
-
-// URL path features
-const char kUrlPathToken[] = "UrlPathToken=";
-
-// DOM HTML form features
-const char kPageHasForms[] = "PageHasForms";
-const char kPageActionOtherDomainFreq[] = "PageActionOtherDomainFreq";
-const char kPageActionURL[] = "PageActionURL=";
-const char kPageHasTextInputs[] = "PageHasTextInputs";
-const char kPageHasPswdInputs[] = "PageHasPswdInputs";
-const char kPageHasRadioInputs[] = "PageHasRadioInputs";
-const char kPageHasCheckInputs[] = "PageHasCheckInputs";
-
-// DOM HTML link features
-const char kPageExternalLinksFreq[] = "PageExternalLinksFreq";
-const char kPageLinkDomain[] = "PageLinkDomain=";
-const char kPageSecureLinksFreq[] = "PageSecureLinksFreq";
-
-// DOM HTML script features
-const char kPageNumScriptTagsGTOne[] = "PageNumScriptTags>1";
-const char kPageNumScriptTagsGTSix[] = "PageNumScriptTags>6";
-
-// Other DOM HTML features
-const char kPageImgOtherDomainFreq[] = "PageImgOtherDomainFreq";
-
-// Page term features
-const char kPageTerm[] = "PageTerm=";
-
-} // namespace features
-} // namespace safe_browsing
« no previous file with comments | « chrome/renderer/safe_browsing/features.h ('k') | chrome/renderer/safe_browsing/features_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698