Mac QICRCodeFeature: forward declare in base/mac/sdk_forward_declarations.h

Mac: forward declare CIQRCodeFeature in base/mac/sdk_forward_declarations.h

CIQRCodeFeature [1] is an interface in the CoreImage framework (which at a time
was part of the QuartzCore framework) and is used to detect QR Codes in
images.  CIQRCodeFeature is only available in Mac OS X 10.10+, which is fine
for the bots bug causes warnings elsewhere:

.../CoreImage.framework/Headers/CIFeature.h:113:12: note: 'CIQRCodeFeature' has been explicitly marked partial here
@interface CIQRCodeFeature : CIFeature
           ^
../../services/shape_detection/barcode_detection_impl_mac.mm:69:8: note: enclose 'CIQRCodeFeature' in an @available check to silence this warning

This CL adds it to sdk_forward_declarations so it's forward-defined when
needed.

[1] https://developer.apple.com/reference/coreimage/ciqrcodefeature?language=objc

BUG=665150
TBR=rockot

Review-Url: https://codereview.chromium.org/2667283006
Cr-Commit-Position: refs/heads/master@{#448092}
Committed: https://chromium.googlesource.com/chromium/src/+/7058aa1630b1508762a87d3fee3918e42c3046f7

[mcasas, 2017-02-03 19:00:08]

Patchset #1 (id:1) has been deleted

[mcasas, 2017-02-03 19:04:08]

mcasas@chromium.org changed reviewers:
+ rsesek@chromium.org, thakis@chromium.org

[mcasas, 2017-02-03 19:04:08]

thakis@/rsesek@ PTAL

[Sunny, 2017-02-03 19:07:33]

On 2017/02/03 19:04:08, mcasas wrote:
> thakis@/rsesek@ PTAL

Oops...Seems the issues I mentioned still exists after I apply this patch

[Nico, 2017-02-03 19:25:45]

https://codereview.chromium.org/2667283006/diff/20001/services/shape_detectio...
File services/shape_detection/face_detection_impl_mac.mm (right):

https://codereview.chromium.org/2667283006/diff/20001/services/shape_detectio...
services/shape_detection/face_detection_impl_mac.mm:12: #include
"services/shape_detection/detection_utils_mac.h"
do you need to include forward_declarations here?

[mcasas, 2017-02-03 21:04:16]

Managed to repro locally by adding
use_system_xcode = true
to my local args.gn, and managed to build
a Chromium all right.  

PTAL again

https://codereview.chromium.org/2667283006/diff/20001/services/shape_detectio...
File services/shape_detection/face_detection_impl_mac.mm (right):

https://codereview.chromium.org/2667283006/diff/20001/services/shape_detectio...
services/shape_detection/face_detection_impl_mac.mm:12: #include
"services/shape_detection/detection_utils_mac.h"
On 2017/02/03 19:25:45, Nico wrote:
> do you need to include forward_declarations here?

I don't: Face detection was fully available in 10.9.

[Nico, 2017-02-03 21:06:01]

lgtm

[mcasas, 2017-02-03 21:14:24]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 21:14:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2017-02-03 21:26:29]

mcasas@chromium.org changed reviewers:
+ rockot@chromium.org

[mcasas, 2017-02-03 21:26:29]

rockot@ RS plz tiny changes in services/shape_detection

[commit-bot: I haz the power, 2017-02-03 21:41:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 21:41:02]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-02-03 22:19:23]

On 2017/02/03 21:26:29, mcasas wrote:
> rockot@ RS plz tiny changes in services/shape_detection

Given that this is a small change and it unbreaks people, I think it's cool to
TBR this.

[Nico, 2017-02-03 22:31:44]

Description was changed from

==========
Mac: forward declare CIQRCodeFeature in base/mac/sdk_forward_declarations.h

CIQRCodeFeature [1] is an interface in the CoreImage framework (which at a time
was part of the QuartzCore framework) and is used to detect QR Codes in
images.  CIQRCodeFeature is only available in Mac OS X 10.10+, which is fine
for the bots bug causes warnings elsewhere:

.../CoreImage.framework/Headers/CIFeature.h:113:12: note: 'CIQRCodeFeature' has
been explicitly marked partial here
@interface CIQRCodeFeature : CIFeature
           ^
../../services/shape_detection/barcode_detection_impl_mac.mm:69:8: note: enclose
'CIQRCodeFeature' in an @available check to silence this warning

This CL adds it to sdk_forward_declarations so it's forward-defined when
needed.

[1]
https://developer.apple.com/reference/coreimage/ciqrcodefeature?language=objc

BUG=665150
==========

to

==========
Mac: forward declare CIQRCodeFeature in base/mac/sdk_forward_declarations.h

CIQRCodeFeature [1] is an interface in the CoreImage framework (which at a time
was part of the QuartzCore framework) and is used to detect QR Codes in
images.  CIQRCodeFeature is only available in Mac OS X 10.10+, which is fine
for the bots bug causes warnings elsewhere:

.../CoreImage.framework/Headers/CIFeature.h:113:12: note: 'CIQRCodeFeature' has
been explicitly marked partial here
@interface CIQRCodeFeature : CIFeature
           ^
../../services/shape_detection/barcode_detection_impl_mac.mm:69:8: note: enclose
'CIQRCodeFeature' in an @available check to silence this warning

This CL adds it to sdk_forward_declarations so it's forward-defined when
needed.

[1]
https://developer.apple.com/reference/coreimage/ciqrcodefeature?language=objc

BUG=665150
TBR=rockot
==========

[Nico, 2017-02-03 22:31:48]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-02-03 22:32:01]

(added a TBR line and clicked cq)

[commit-bot: I haz the power, 2017-02-03 22:32:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 22:40:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486161108116310,
"parent_rev": "e6bdce91ea04fef44d930969cf7e84708a8bd35c", "commit_rev":
"7058aa1630b1508762a87d3fee3918e42c3046f7"}

[commit-bot: I haz the power, 2017-02-03 22:40:31]

Description was changed from

==========
Mac: forward declare CIQRCodeFeature in base/mac/sdk_forward_declarations.h

CIQRCodeFeature [1] is an interface in the CoreImage framework (which at a time
was part of the QuartzCore framework) and is used to detect QR Codes in
images.  CIQRCodeFeature is only available in Mac OS X 10.10+, which is fine
for the bots bug causes warnings elsewhere:

.../CoreImage.framework/Headers/CIFeature.h:113:12: note: 'CIQRCodeFeature' has
been explicitly marked partial here
@interface CIQRCodeFeature : CIFeature
           ^
../../services/shape_detection/barcode_detection_impl_mac.mm:69:8: note: enclose
'CIQRCodeFeature' in an @available check to silence this warning

This CL adds it to sdk_forward_declarations so it's forward-defined when
needed.

[1]
https://developer.apple.com/reference/coreimage/ciqrcodefeature?language=objc

BUG=665150
TBR=rockot
==========

to

==========
Mac: forward declare CIQRCodeFeature in base/mac/sdk_forward_declarations.h

CIQRCodeFeature [1] is an interface in the CoreImage framework (which at a time
was part of the QuartzCore framework) and is used to detect QR Codes in
images.  CIQRCodeFeature is only available in Mac OS X 10.10+, which is fine
for the bots bug causes warnings elsewhere:

.../CoreImage.framework/Headers/CIFeature.h:113:12: note: 'CIQRCodeFeature' has
been explicitly marked partial here
@interface CIQRCodeFeature : CIFeature
           ^
../../services/shape_detection/barcode_detection_impl_mac.mm:69:8: note: enclose
'CIQRCodeFeature' in an @available check to silence this warning

This CL adds it to sdk_forward_declarations so it's forward-defined when
needed.

[1]
https://developer.apple.com/reference/coreimage/ciqrcodefeature?language=objc

BUG=665150
TBR=rockot

Review-Url: https://codereview.chromium.org/2667283006
Cr-Commit-Position: refs/heads/master@{#448092}
Committed:
https://chromium.googlesource.com/chromium/src/+/7058aa1630b1508762a87d3fee39...
==========

[commit-bot: I haz the power, 2017-02-03 22:40:32]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7058aa1630b1508762a87d3fee39...