Mac QICRCodeFeature: forward declare in base/mac/sdk_forward_declarations.h

services/shape_detection/face_detection_impl_mac.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/shape_detection/face_detection_impl_mac.h"
 
+#import <QuartzCore/QuartzCore.h>
+
 #include "base/mac/scoped_cftyperef.h"
 #include "media/capture/video/scoped_result_callback.h"
 #include "mojo/public/cpp/bindings/strong_binding.h"
 #include "services/shape_detection/detection_utils_mac.h"

[Nico, 2017/02/03 19:25:45]

do you need to include forward_declarations here?

[mcasas, 2017/02/03 21:04:16]

I don't: Face detection was fully available in 10.9.

 #include "services/shape_detection/face_detection_provider_impl.h"
 
 namespace shape_detection {
 
 namespace {
 
 void RunCallbackWithFaces(
     const shape_detection::mojom::FaceDetection::DetectCallback& callback,
     shape_detection::mojom::FaceDetectionResultPtr faces) {
   callback.Run(std::move(faces));
@@ skipping 47 matching lines @@
     // We need to adjust |y| coordinate of bounding box before sending it.
     gfx::RectF boundingbox(f.bounds.origin.x,
                            height - f.bounds.origin.y - f.bounds.size.height,
                            f.bounds.size.width, f.bounds.size.height);
     faces->bounding_boxes.push_back(boundingbox);
   }
   scoped_callback.Run(std::move(faces));
 }
 
 }  // namespace shape_detection