Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2667263002: android: Move JavaExceptionReporter to base (Closed)

Created:
3 years, 10 months ago by boliu
Modified:
3 years, 10 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Move JavaExceptionReporter to base So that it can be used in other processes as well. There as some comment changes, and added @MainDex. But otherwise a straightforward move. BUG=680775 Review-Url: https://codereview.chromium.org/2667263002 Cr-Commit-Position: refs/heads/master@{#448000} Committed: https://chromium.googlesource.com/chromium/src/+/9b51b5184179dd0a76fdc4e0e851b22a8aa842d5

Patch Set 1 #

Patch Set 2 : bring back ui thread #

Patch Set 3 : maindex #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -151 lines) Patch
M base/BUILD.gn View 1 3 chunks +4 lines, -0 lines 0 comments Download
M base/android/base_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A + base/android/java/src/org/chromium/base/JavaExceptionReporter.java View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
A base/android/java_exception_reporter.h View 1 chunk +23 lines, -0 lines 0 comments Download
A + base/android/java_exception_reporter.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/JavaExceptionReporter.java View 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/android/java_sources.gni View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/browser/android/java_exception_reporter.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/android/java_exception_reporter.cc View 1 chunk +0 lines, -50 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
boliu
ptal torne for base tedchoc for android stuff under chrome
3 years, 10 months ago (2017-02-02 03:55:50 UTC) #2
Torne
The UI thread is a concept maintained in base and there's other code in base ...
3 years, 10 months ago (2017-02-02 14:33:05 UTC) #3
boliu
alright, UI check is back
3 years, 10 months ago (2017-02-02 15:10:44 UTC) #5
Torne
lgtm
3 years, 10 months ago (2017-02-02 15:14:03 UTC) #6
Ted C
chrome - lgtm
3 years, 10 months ago (2017-02-02 17:34:07 UTC) #7
boliu
oh, one more change to base, added @MainDex, because intention is this will be used ...
3 years, 10 months ago (2017-02-02 17:48:26 UTC) #8
boliu
+cpu to stamp chrome/app
3 years, 10 months ago (2017-02-02 17:50:31 UTC) #11
boliu
+grt for chrome/app Not sure if cpu@ is working on chromium..
3 years, 10 months ago (2017-02-02 23:35:47 UTC) #13
grt (UTC plus 2)
chrome/app/chrome_main_delegate.cc lgtn
3 years, 10 months ago (2017-02-03 08:18:06 UTC) #14
grt (UTC plus 2)
On 2017/02/03 08:18:06, grt (UTC plus 1) wrote: > chrome/app/chrome_main_delegate.cc lgtn lgtm, too!
3 years, 10 months ago (2017-02-03 08:18:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667263002/40001
3 years, 10 months ago (2017-02-03 14:23:34 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 15:35:51 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9b51b5184179dd0a76fdc4e0e851...

Powered by Google App Engine
This is Rietveld 408576698