Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3133)

Unified Diff: base/android/java/src/org/chromium/base/JavaExceptionReporter.java

Issue 2667263002: android: Move JavaExceptionReporter to base (Closed)
Patch Set: maindex Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/base_jni_registrar.cc ('k') | base/android/java_exception_reporter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/java/src/org/chromium/base/JavaExceptionReporter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/JavaExceptionReporter.java b/base/android/java/src/org/chromium/base/JavaExceptionReporter.java
similarity index 86%
rename from chrome/android/java/src/org/chromium/chrome/browser/JavaExceptionReporter.java
rename to base/android/java/src/org/chromium/base/JavaExceptionReporter.java
index 5e42c80f3b40552e765179cac210492574438a6e..ada0bae0cb206bcf16d0c3126efc7387bd52da5d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/JavaExceptionReporter.java
+++ b/base/android/java/src/org/chromium/base/JavaExceptionReporter.java
@@ -2,27 +2,28 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-package org.chromium.chrome.browser;
+package org.chromium.base;
import android.support.annotation.UiThread;
-import org.chromium.base.ThreadUtils;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
+import org.chromium.base.annotations.MainDex;
/**
* This UncaughtExceptionHandler will create a breakpad minidump when there is an uncaught
* exception.
*
- * The exception's stack trace will be added to the minidump's data. This allows us to report
- * java-only crashes in the same way that we report all other Chrome crashes.
+ * The exception's stack trace will be added to the minidump's data. This allows java-only crashes
+ * to be reported in the same way as other native crashes.
*/
-@JNINamespace("chrome::android")
+@JNINamespace("base::android")
+@MainDex
public class JavaExceptionReporter implements Thread.UncaughtExceptionHandler {
private Thread.UncaughtExceptionHandler mParent;
private boolean mHandlingException;
- JavaExceptionReporter(Thread.UncaughtExceptionHandler parent) {
+ private JavaExceptionReporter(Thread.UncaughtExceptionHandler parent) {
mParent = parent;
}
« no previous file with comments | « base/android/base_jni_registrar.cc ('k') | base/android/java_exception_reporter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698