Convert BiquadFilter response tests to testharness

Convert BiquadFilter response tests to testharness

Convert tests of the filter responses to use testharness and new
Audit.

BUG=687307
TEST=biquad-allpass.html, biquad-bandpass.html, biquad-highpass.html,
biquad-highshelf.html, biquad-lowpass.html, biquad-lowshelf.html,
biquad-notch.html, biquad-peaking.html

Review-Url: https://codereview.chromium.org/2667153002
Cr-Commit-Position: refs/heads/master@{#447849}
Committed: https://chromium.googlesource.com/chromium/src/+/b6c30239d7d6a2f2db9c37571df96dd73c9300d6

[Raymond Toy, 2017-02-01 16:35:05]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-02-01 16:35:06]

PTAL

[hongchan, 2017-02-01 18:18:47]

Is this change done manually?

Also mixing let/var is confusing. I don't feel strong about it, but it would be
better if we can just comeback to this and run 'clang-format' with sprinkle ES6
goodness later.

https://codereview.chromium.org/2667153002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/biquad-testing.js
(right):

https://codereview.chromium.org/2667153002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/biquad-testing.js:81:
checkFilterResponse(filterType, testParameters)(buffer);
This looks a bit off. I know it's a valid expression, but can we some how fix
this?

[Raymond Toy, 2017-02-01 19:08:53]

Because the test use testPasse/Failed, the changes have to be done by hand.

I fine if you want to reindent the biquad-*.html files. I'm not so keen on doing
that for biquad-testing.js in this CL since only a few changes were needed to
convert to testharness and new Audit.

https://codereview.chromium.org/2667153002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/biquad-testing.js
(right):

https://codereview.chromium.org/2667153002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/biquad-testing.js:81:
checkFilterResponse(filterType, testParameters)(buffer);
On 2017/02/01 18:18:47, hongchan wrote:
> This looks a bit off. I know it's a valid expression, but can we some how fix
> this?

Yeah, this can be fixed. I was going for minimal changes, but the fix is also
small.

[hongchan, 2017-02-02 19:42:02]

lgtm

[Raymond Toy, 2017-02-02 19:49:39]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-02-02 19:49:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 21:39:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486064979872820,
"parent_rev": "537181f43f30baf668b1fd2a52893b789ada2198", "commit_rev":
"b6c30239d7d6a2f2db9c37571df96dd73c9300d6"}

[commit-bot: I haz the power, 2017-02-02 21:40:10]

Description was changed from

==========
Convert BiquadFilter response tests to testharness

Convert tests of the filter responses to use testharness and new
Audit.

BUG=687307
TEST=biquad-allpass.html, biquad-bandpass.html, biquad-highpass.html,
biquad-highshelf.html, biquad-lowpass.html, biquad-lowshelf.html,
biquad-notch.html, biquad-peaking.html
==========

to

==========
Convert BiquadFilter response tests to testharness

Convert tests of the filter responses to use testharness and new
Audit.

BUG=687307
TEST=biquad-allpass.html, biquad-bandpass.html, biquad-highpass.html,
biquad-highshelf.html, biquad-lowpass.html, biquad-lowshelf.html,
biquad-notch.html, biquad-peaking.html

Review-Url: https://codereview.chromium.org/2667153002
Cr-Commit-Position: refs/heads/master@{#447849}
Committed:
https://chromium.googlesource.com/chromium/src/+/b6c30239d7d6a2f2db9c37571df9...
==========

[commit-bot: I haz the power, 2017-02-02 21:40:11]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b6c30239d7d6a2f2db9c37571df9...